add datasets functions #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fuji44
commented
Nov 3, 2022
fuji44
commented
- see: https://github.com/fastlabel/fastlabel-application/issues/1154
- dependent
- Reconfigure the linter and formatter correctly. And reflect it throughout. #127
- https://github.com/fastlabel/fastlabel-application/pull/3081
ueno-k-work
reviewed
Nov 10, 2022
Contributor
ueno-k-work
left a comment
ueno-k-work
left a comment
There was a problem hiding this comment.
@fuji44
すいません、先にいただいていたフォーマット関連のPRはマージ済みなのですが、、
本PRでそれらと同じ内容が差分として登場してしまいます。。
一応、目検で今回の修正対象の差分だけ確認はしているのですが、もし可能であればリベースする等で綺麗にすることはできますか。。？
fuji44
force-pushed
the
feature/1154-add-dataset-function
branch
from
a5007f1 to
479f548
Compare
Contributor
Author
|
@ueno-k-work |
ueno-k-work
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.