Skip to content

fix: support h264 that was previously determined to be avc1 #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2024
Merged

fix: support h264 that was previously determined to be avc1 #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
342811c
add h264
hukurou0 Jun 6, 2024
5552cc6
fix error message
hukurou0 Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fastlabel/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1267,7 +1267,7 @@ def create_video_task(
)
if not utils.is_video_supported_codec(file_path):
raise FastLabelInvalidException(
"Supported video encoding for registration through the SDK is only H.264.",
"Supported video encoding for registration through the SDK is only AVC/H.264",
422,
)

Expand Down Expand Up @@ -1336,7 +1336,7 @@ def create_video_classification_task(
)
if not utils.is_video_supported_codec(file_path):
raise FastLabelInvalidException(
"Supported video encoding for registration through the SDK is only H.264.",
"Supported video encoding for registration through the SDK is only AVC/H.264",
422,
)

Expand Down
2 changes: 1 addition & 1 deletion fastlabel/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@
SUPPORTED_OBJECT_SIZE = 250 * math.pow(1024, 2)

# Only 'avc1' and 'H264' are supported for video task creation.
SUPPORTED_FOURCC = ["avc1"]
SUPPORTED_FOURCC = ["avc1", "h264"]


SUPPORTED_INFERENCE_IMAGE_SIZE = 6 * math.pow(1024, 2)
Expand Down