Skip to content

Conversation

@qoone
Copy link
Contributor

@qoone qoone commented Oct 4, 2021

No description provided.

@qoone qoone requested a review from faycute October 4, 2021 08:02
@qoone qoone changed the title WIP:convert to fastlabel json logic convert to fastlabel json logic Oct 10, 2021

### COCO

Supported bbox or polygon annotation type.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

骨格推定は今後だっけ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CREATEのAPIで骨格推定に対応する必要があるから、今後の対応になる想定。

issueに登録しておく必要があると思うけど、登録しておいたらいい?(そもそも俺が登録できる?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

登録お願い!できるはず
試してもらっていい?
登録ルールはここに書いてる
https://github.com/fastlabel/fastlabel-application/wiki/%E3%82%A4%E3%82%B7%E3%83%A5%E3%83%BC%E7%AE%A1%E7%90%86

yolo_annotations[annotaion_key].append(anno_line.strip().split(" "))
return yolo_annotations

def get_image_path(self, image_folder_path) -> dict:
Copy link
Contributor

@faycute faycute Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これはユーザーのためのutil的な?
あとget_image_paths_mapでは?

Copy link
Contributor

@faycute faycute Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使い方をコメントで残して欲しい!
inputとoutputを明確に

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

んーなんかわかりにくいからどこかで話そう!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for file_path in glob.iglob(os.path.join(INPUT_PATH, "**/**.png"), recursive=True):

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_image_pathは削除して、READMEに画像のパスを取得する形のサンプルを追加した。

3364954#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R1058


# Convert to Fastlabel

def convert_coco_to_fastlabel(self, file_path: str) -> dict:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outputフォーマットの説明が欲しい!他のも

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応した。

da5f871

...
}
"""
image_types = ["jpg", "jpeg", "png"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utilに切り出す

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faycute faycute merged commit a0938dc into develop Nov 2, 2021
@faycute faycute deleted the feature/convert-other-format-to-fastlabel-format branch November 2, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants