Skip to content

Upgrade to Rust 1.95#604

Merged
kailan merged 2 commits intomainfrom
rust-1.95
Apr 24, 2026
Merged

Upgrade to Rust 1.95#604
kailan merged 2 commits intomainfrom
rust-1.95

Conversation

@kailan
Copy link
Copy Markdown
Member

@kailan kailan commented Apr 20, 2026

No description provided.

@kailan kailan requested a review from a team April 20, 2026 10:19
@kailan kailan added the maintenance Maintenance and gardening label Apr 20, 2026
@kailan kailan mentioned this pull request Apr 21, 2026
Base automatically changed from clippy to main April 24, 2026 13:36
@kailan kailan requested a review from kpfleming April 24, 2026 13:38
@kailan kailan enabled auto-merge April 24, 2026 13:39
@kpfleming
Copy link
Copy Markdown
Member

Would you consider making a slightly different set of changes? With rust-toolchain.toml in place, there shouldn't be any need to specify a Rust version anywhere else (in configuration files or workflows), and there should not be any need to invoke rustup to install, uninstall, or set default either. That change would result in the version being specified in only one location and eliminate the risk of version mismatches.

We don't need to set rust-version in cli/Cargo.toml since that crate is not intended for re-use; for the top-level Cargo.toml (the viceroy-lib crate) the rust-version sets the MSRV for the crate, it does not specify the compiler version to be used when building it. That means it should be set to some reasonably recent version which is compatible with the source code, but doesn't need to be any newer.

If you'd prefer, I'd be happy to make the changes in this branch instead.

@kailan
Copy link
Copy Markdown
Member Author

kailan commented Apr 24, 2026

Would you consider making a slightly different set of changes? With rust-toolchain.toml in place, there shouldn't be any need to specify a Rust version anywhere else

I'll give it a go!

Comment thread Dockerfile

# Install Rust, rustfmt, and the wasm32-wasi cross-compilation target
RUN curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain 1.52.1 -y
RUN curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain stable -y
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No harm making this change, but it doesn't appear that this Dockerfile is being used anywhere in the repository and it just builds a very simple image containing rustup and Rust.

@kailan kailan merged commit 8308a40 into main Apr 24, 2026
14 checks passed
@kailan kailan deleted the rust-1.95 branch April 24, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance and gardening

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants