Skip to content

[CDTOOL-1269] Refactor commands to use updated testing framework#1650

Merged
rcaril merged 7 commits intomainfrom
rcaril/CDTOOL-1269-refactor-commands-using-old-scenario-framework
Mar 5, 2026
Merged

[CDTOOL-1269] Refactor commands to use updated testing framework#1650
rcaril merged 7 commits intomainfrom
rcaril/CDTOOL-1269-refactor-commands-using-old-scenario-framework

Conversation

@rcaril
Copy link
Contributor

@rcaril rcaril commented Feb 4, 2026

Change summary

This PR updates the tests for service and stats commands to the newer version of our test framework.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

None, these are simply test updates.

@rcaril rcaril changed the title refactor simple commands [CDTOOL-1269] Refactor commands to use updated testing framework Feb 4, 2026
@rcaril rcaril added the Skip-Changelog do not add a changelog entry for this change label Feb 4, 2026
@rcaril
Copy link
Contributor Author

rcaril commented Feb 4, 2026

 make test TEST_ARGS="-run TestServiceAuthCreate ./pkg/commands/service/auth"
ok      github.com/fastly/cli/pkg/commands/service/auth 1.081s

make test TEST_ARGS="-run TestServiceAuthList ./pkg/commands/service/auth"
ok      github.com/fastly/cli/pkg/commands/service/auth 1.094s

 make test TEST_ARGS="-run TestServiceAuthDescribe ./pkg/commands/service/auth"
ok      github.com/fastly/cli/pkg/commands/service/auth 1.097s

make test TEST_ARGS="-run TestServiceAuthUpdate ./pkg/commands/service/auth"
ok      github.com/fastly/cli/pkg/commands/service/auth 1.088s

make test TEST_ARGS="-run TestServiceAuthDelete ./pkg/commands/service/auth"
ok      github.com/fastly/cli/pkg/commands/service/auth 1.076s

--
make test TEST_ARGS="-run TestServiceCreate ./pkg/commands/service"
ok      github.com/fastly/cli/pkg/commands/service      1.102s

make test TEST_ARGS="-run TestServiceList ./pkg/commands/service"
ok      github.com/fastly/cli/pkg/commands/service      1.073s

make test TEST_ARGS="-run TestServiceDescribe ./pkg/commands/service"
ok      github.com/fastly/cli/pkg/commands/service      1.097s

make test TEST_ARGS="-run TestServiceSearch ./pkg/commands/service"
ok      github.com/fastly/cli/pkg/commands/service      1.091s

make test TEST_ARGS="-run TestServiceUpdate ./pkg/commands/service"
ok      github.com/fastly/cli/pkg/commands/service      1.128s

--

make test TEST_ARGS="-run TestRegions ./pkg/commands/stats"
ok      github.com/fastly/cli/pkg/commands/stats        1.046s

--
 make test TEST_ARGS="-run TestHistorical ./pkg/commands/stats"
ok      github.com/fastly/cli/pkg/commands/stats        1.064s

@rcaril rcaril marked this pull request as ready for review February 27, 2026 16:03
@rcaril rcaril requested a review from a team as a code owner February 27, 2026 16:03
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. It looks to me that some args and therefore test cases have change. Please double check and maybe there is a good reason for it but in general I would prefer if they would stay the same. Thanks!

Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

…at were added in this branch to improve readability.
@rcaril rcaril requested a review from philippschulte March 2, 2026 19:00
@rcaril
Copy link
Contributor Author

rcaril commented Mar 2, 2026

Added the Name field in these updated tests for a clearer picture of what is being tested.
b9a28ae

@rcaril rcaril merged commit b56d0b4 into main Mar 5, 2026
13 checks passed
@rcaril rcaril deleted the rcaril/CDTOOL-1269-refactor-commands-using-old-scenario-framework branch March 5, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip-Changelog do not add a changelog entry for this change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants