Skip to content

[CDTOOL-1304] Ensure that the Fastly Auth type commands respect the --quiet Flag#1710

Merged
rcaril merged 2 commits intomainfrom
rcaril/CDTOOL-1304-ensure-auth-commands-respect-quiet-flag
Mar 23, 2026
Merged

[CDTOOL-1304] Ensure that the Fastly Auth type commands respect the --quiet Flag#1710
rcaril merged 2 commits intomainfrom
rcaril/CDTOOL-1304-ensure-auth-commands-respect-quiet-flag

Conversation

@rcaril
Copy link
Contributor

@rcaril rcaril commented Mar 23, 2026

Change summary

This PR corrects a bug where the fastly profile, fastly sso and fastly auth-token commands were not checking the the --quiet flag.

Fixes issue #1708.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?
 make test TEST_ARGS="-run TestProfileToken ./pkg/commands/profile"  
ok      github.com/fastly/cli/pkg/commands/profile      1.171s

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

rcaril added 2 commits March 23, 2026 14:29
… auth-token` commands now correctly respect the `--quiet` flag

Wrapped the deprication warnings with a check for the `--quiet` flag
@rcaril rcaril marked this pull request as ready for review March 23, 2026 18:39
@rcaril rcaril requested a review from a team as a code owner March 23, 2026 18:39
Copy link
Contributor

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've got a long-standing open issue to direct this type of output to stderr instead of stdout which would also be an improvement, but this is fine for now :-)

@rcaril rcaril merged commit 4f86396 into main Mar 23, 2026
13 checks passed
@rcaril rcaril deleted the rcaril/CDTOOL-1304-ensure-auth-commands-respect-quiet-flag branch March 23, 2026 18:47
jedisct1 added a commit that referenced this pull request Mar 23, 2026
* main:
  [CDTOOL-1304] Ensure that the Fastly Auth type commands respect the `--quiet` Flag (#1710)
  build(deps): bump the go-dependencies group with 2 updates (#1707)
  [CDTOOL-1102]  Add support for the `service vcl snippet describe` `--content` flag (#1706)
  SSO warnings: write "session expires in ..." when refresh token is present (#1685)

# Conflicts:
#	pkg/app/run.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants