Conversation
5 tasks
rcaril
commented
May 7, 2026
ulyssa
approved these changes
May 7, 2026
philippschulte
requested changes
May 7, 2026
Member
philippschulte
left a comment
There was a problem hiding this comment.
The implementation looks good to me overall. One small consistency nitt: CreateCommand.MaxUse and CreateCommand.MaxLifetime should probably be unexported as maxUse and maxLifetime, matching nearby fields like maxConn, firstByteTimeout, and healthCheck. They do not appear to need to be exported. The update command already uses exported fields consistently, so no issue there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
This PR adds new
--max-useand--max-lifetimeparameters tofastly service backend createandfastly service backend update, which can be used to specify themax_useandmax_lifetimebackend fields.All Submissions:
New Feature Submissions:
Changes to Core Features: