fix(compute): ignore attribute-only (Chmod) events in serve --watch#1808
Open
case wants to merge 2 commits into
Open
fix(compute): ignore attribute-only (Chmod) events in serve --watch#1808case wants to merge 2 commits into
case wants to merge 2 commits into
Conversation
jedisct1
reviewed
Jun 2, 2026
| // (Create/Write/Remove/Rename) and not an attribute-only Chmod. fsnotify | ||
| // recommends ignoring Chmod; see its "Why do I get many Chmod events?" FAQ: | ||
| // https://github.com/fsnotify/fsnotify#why-do-i-get-many-chmod-events | ||
| func isContentChange(op fsnotify.Op) bool { |
Contributor
There was a problem hiding this comment.
isContentChange may be a bit confusing as it returns true for remove and rename operations, which don't really change the content. But naming things is hard :)
Author
There was a problem hiding this comment.
Thanks @jedisct1! Would you prefer a different name? (e.g. is this blocking merging the PR?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
This fixes #1332. The problem is described in the
fsnotifyreadme - "As a rule, it's typically best to ignore Chmod events."All Submissions:
New Feature Submissions:
Changes to Core Features:
User Impact
The infinite rebuild loop / flapping in #1332 is fixed.
Are there any considerations that need to be addressed for release?
None.