Improve KV Store Publishing algorithm #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harmony7
force-pushed
the
kats/improve-kv-store-publish
branch
from
ff7b6b0 to
bae8f8b
Compare
harmony7
force-pushed
the
kats/improve-kv-store-publish
branch
from
bae8f8b to
0f0361f
Compare
kpfleming
requested changes
Mar 24, 2025
Member
Author
|
@kpfleming I have added said comment, I hope the above makes sense =) |
kpfleming
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
Node.js 20 is now a requirement. This is a version of Node.js where fetch() is marked as "Stable"
callFastlyApinow throwsFetchError, a custom error type that includes the status code. This simplifies error handling logic as error status codes and connection problems can be handled/retried together.retryablecan mark certain errors as "possible to retry". This includes certain error codes as well as problems with the network (fetch itself failing).A "fetch pool" of 12 concurrent workers all submitting to the KV store in parallel. This speeds up publishes. Whenever a submit fails, there is a backoff for retries so that the system tries again.
Some TypeScript code cleanup
Fixes #29