Conversation
Collaborator
Author
|
Fixes #41 |
82cbfd2 to
0cd49f4
Compare
zkat
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements support for Edge Rate Limiting.
The SDK functions are very thin wrappers around the hostcalls, so this is the first time that we are directly calling into the host from C++ rather than going via Rust. I chose to pull over parts of
fastly.hfrom the JS SDK and make some modifications for ergonomics. We can pull over more of this as we slowly move parts of the C++ SDK over to hostcalls.This also bumps the Rust toolchain version, which is now required to build Viceroy in CI, and allows a new clippy warning