Write correct producers metadata to generated components#86
Merged
Conversation
erikrose
approved these changes
Apr 13, 2026
| kind = next(iter(node)) | ||
| data = node[kind] | ||
| if kind == "module": | ||
| m = re.match(r"libpython(\d+\.\d+)\.so", data.get("name") or "") |
Member
Author
There was a problem hiding this comment.
Ah, that's right, in the JSON this key is sometimes present with a value that is null (None in Python). I just made this path a bit more explicit in the updates.
| return m.group(1) | ||
| else: | ||
| nodes.extend(data.get("children", [])) | ||
| return None |
These changes updates fastly-compute-py to inject appropriate
producer metadata to our generated component at the top-level.
Here's what we get with this change:
$ wasm-tools metadata show build/bottle-app.composed.wasm --json | jq '.component.metadata.producers[]'
[
"language",
{
"Python": "3.14"
}
]
[
"processed-by",
{
"componentize-py": "0.22.1",
"fastly-compute-py": "0.1.0"
}
]
[
"sdk",
{
"fastly-compute-py": "0.1.0"
}
]
posborne
force-pushed
the
posborne/python-component-metadata
branch
from
4dce92b to
4fd8544
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes updates fastly-compute-py to inject appropriate producer metadata to our generated component at the top-level. Here's what we get with this change: