make retry/recovery optional on first subscriptions#48218
Merged
Conversation
serra-fastly
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally, whenever a channel gains its first subscribing session, a short moment later every session subscribed to that channel will have its retry or recovery mechanism invoked. (Note: often this is not many sessions since it is only triggered when the number of sessions for the channel goes from zero to one.)
This behavior exists to work around a race between subscription notifications and the next message being published to the channel, in environments where messages are only relayed to Pushpin for known subscriptions. However, this behavior may not be desirable in all environments, for example where messages are sent to Pushpin unconditionally, or where the side effects of the race are tolerable. This PR makes it optional.