memorypool: optimize rc a little more#48306
Merged
Conversation
deg4uss3r
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point during the recent memorypool refactoring I added the slab key to the
RcInnerstruct in order to speed updrop. This caused a regression in the benchmarks, likely due to the increased struct size resulting in less CPU caching. Reverting it restores the expected performance.Doing it this way requires the
key_ofmethod from the slab crate, which I've copied into to our fork. I should note that a new version of the slab crate was published which has our element removal performance fix, so we can probably discard our fork and switch back to the crate now, but I'll do that in a separate PR.