update build image to use latest clang-format#48332
Merged
Conversation
deg4uss3r
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #48328, the C++ files were reformatted using clang-format version 22 from Homebrew. However, the version in the build image is 18 and produces different formatting results, which means we can't use it for enforcement in CI. This PR updates the build image to use version 20, which is the latest stable and for our purposes it appears to be compatible with 22.
I'm not sure why the Homebrew formula is of an unstable release but I guess we can just be happy the versions are compatible at this time. It is possible to access version 20 on Homebrew by installing the LLVM formula, but this is a bit heavy handed and since it doesn't appear necessary I don't recommend it.
I pushed a new build image with these changes, so the CI jobs on this PR are using the updated image. I also posted a draft PR (#48330) based on this PR to test enforcement.