memorypool: rename Memory to MemoryPool, and use Rc internally#48343
Merged
Conversation
jkarneges
force-pushed
the
jkarneges/memory-pool-type
branch
2 times, most recently
from
ddec484 to
8063f80
Compare
jkarneges
force-pushed
the
jkarneges/memory-pool-type
branch
from
8063f80 to
43dfa42
Compare
clintjedwards
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames the
Memorytype toMemoryPoolfor clarity. It also wraps its inner data instd::rc::Rcso that the type itself is ref counted and callers don't need to supply their own Rc-wrapping, which they are universally doing.