Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several recently-observed errors causing the test suite to fail
A better fix would be to follow numpy/numpy#17079 but this requires reworking the QONNX RNGs a bit more, postponed for now.
Restrict onnxscript version to avoid version conflicts of the
ml_dtypespackage. newer versions of onnxscript needml_dtypes>=0.5but at the moment we havetensorflow>=2.9.0, <=2.14.1in qonnx requirements due to QKeras, which pinsml_dtypes==0.2.0Add xfail to test_floatquant tests which seem to have broken due to some interface change, pending further investigation.