fix: use raw SVGs for platform logos in download dropdown#5174
Merged
ComputelessComputer merged 2 commits intomainfrom May 4, 2026
Merged
fix: use raw SVGs for platform logos in download dropdown#5174ComputelessComputer merged 2 commits intomainfrom
ComputelessComputer merged 2 commits intomainfrom
Conversation
Swaps the four `simple-icons:*` iconify glyphs (apple, windows, linux) for `<img>` tags pointing at Wikimedia Commons SVGs, matching the existing GitHub octocat pattern in the same hero section. The iconify-icon's apple glyph rendered ~1px above the optical center of the adjacent text, which was visible as a vertical misalignment in the "Download for Apple Silicon" button. `<img>` with the same source the octocat uses centers cleanly with `items-center`. The `Icon` import is no longer used in this file; `@iconify-icon/react` remains a dep (still used by routes/auth.tsx).
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dd370b7. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the iconify glyphs (apple, windows, linux) in the hero download button + dropdown with raw Wikimedia SVGs via
<img>— matching the existing octocat pattern in the same section. Fixes a ~1px vertical misalignment between the apple glyph and "Download for Apple Silicon" text, caused by iconify-icon's shadow-DOM SVG bearing not centering against the text cap-height. Windows and Linux keep their natural colors. Iconify import dropped from this file (still used by auth.tsx).Note
Low Risk
Low risk UI-only change that swaps icon rendering in the home download button/dropdown; main risk is minor visual/CSP/regression due to external SVG image URLs.
Overview
Updates the home page download CTA to stop using
@iconify-icon/reactfor Apple/Windows/Linux logos and instead render raw SVGs via<img>(removing theIconimport fromindex.tsx).This adjusts sizing/styling (e.g., Apple icon inversion) to improve alignment/consistency with the existing GitHub logo approach while keeping the download links and menu behavior unchanged.
Reviewed by Cursor Bugbot for commit d41a21d. Bugbot is set up for automated code reviews on this repo. Configure here.