Skip to content

fix(chat): anchor modal to floating button#5421

Merged
ComputelessComputer merged 1 commit into
mainfrom
fix/chat-modal-bottom-anchor
Jun 1, 2026
Merged

fix(chat): anchor modal to floating button#5421
ComputelessComputer merged 1 commit into
mainfrom
fix/chat-modal-bottom-anchor

Conversation

@ComputelessComputer
Copy link
Copy Markdown
Collaborator

@ComputelessComputer ComputelessComputer commented Jun 1, 2026

Align the floating chat panel to the bottom FAB line and cover the placement with a focused component test.


Note

Medium Risk
Touches floating chat layout, resize math, and tab/chatMode coupling across navigation paths; regressions could affect panel placement or when chat stays open, but behavior is covered by new tests.

Overview
The floating chat panel is bottom-anchored to the FAB line (items-end, transformOrigin: bottom center), with layout driven by a dedicated container rect that uses the floating anchor and, when expanded, stretches to the root container bottom while staying aligned to the anchor.

Resize behavior adds top and corner handles, adjusts handle hit areas, fixes vertical resize to follow pointer movement (not symmetric doubling), and shows corner grip indicators; expanded state clears when the panel hides.

Tab store auto-collapses floating chat when you open, select, or cycle to a different session (or close the active session and land on another); reopening the same session leaves chat open. Toolbar and empty-state tweaks trim icons and polish expand/chat-title controls.

New persistent-chat component tests cover anchoring, resize handles, expand alignment, and expanded reset on close; chat-mode tests cover session-navigation collapse rules.

Reviewed by Cursor Bugbot for commit 7a3def6. Bugbot is set up for automated code reviews on this repo. Configure here.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 1, 2026

Deploy Preview for old-char canceled.

Name Link
🔨 Latest commit 7a3def6
🔍 Latest deploy log https://app.netlify.com/projects/old-char/deploys/6a1d0a6276dfe80008dc5647

@ComputelessComputer ComputelessComputer force-pushed the fix/chat-modal-bottom-anchor branch from 6af4133 to 97deeb7 Compare June 1, 2026 03:28
Comment thread apps/desktop/src/chat/components/persistent-chat.tsx
@ComputelessComputer ComputelessComputer force-pushed the fix/chat-modal-bottom-anchor branch from 97deeb7 to cba29c7 Compare June 1, 2026 03:39
Comment thread apps/desktop/src/store/zustand/tabs/basic.ts
Comment thread apps/desktop/src/store/zustand/tabs/basic.ts
@ComputelessComputer ComputelessComputer force-pushed the fix/chat-modal-bottom-anchor branch from cba29c7 to 7078066 Compare June 1, 2026 03:51
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7078066. Configure here.

Comment thread apps/desktop/src/chat/components/persistent-chat.tsx
Comment thread apps/desktop/src/store/zustand/tabs/basic.ts
@ComputelessComputer ComputelessComputer force-pushed the fix/chat-modal-bottom-anchor branch from 7078066 to d16c318 Compare June 1, 2026 03:58
Align the floating panel with the FAB, keep expanded chat constrained to the note pane while extending to the bottom, add edge and corner resize handles, compact header controls, and collapse chat when switching notes. Cover placement, resizing, and navigation with focused tests.
@ComputelessComputer ComputelessComputer force-pushed the fix/chat-modal-bottom-anchor branch from d16c318 to 7a3def6 Compare June 1, 2026 04:28
@ComputelessComputer ComputelessComputer merged commit 16540a2 into main Jun 1, 2026
15 checks passed
@ComputelessComputer ComputelessComputer deleted the fix/chat-modal-bottom-anchor branch June 1, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant