fix(chat): anchor modal to floating button#5421
Merged
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
6af4133 to
97deeb7
Compare
97deeb7 to
cba29c7
Compare
cba29c7 to
7078066
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7078066. Configure here.
7078066 to
d16c318
Compare
Align the floating panel with the FAB, keep expanded chat constrained to the note pane while extending to the bottom, add edge and corner resize handles, compact header controls, and collapse chat when switching notes. Cover placement, resizing, and navigation with focused tests.
d16c318 to
7a3def6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Align the floating chat panel to the bottom FAB line and cover the placement with a focused component test.
Note
Medium Risk
Touches floating chat layout, resize math, and tab/chatMode coupling across navigation paths; regressions could affect panel placement or when chat stays open, but behavior is covered by new tests.
Overview
The floating chat panel is bottom-anchored to the FAB line (
items-end,transformOrigin: bottom center), with layout driven by a dedicated container rect that uses the floating anchor and, when expanded, stretches to the root container bottom while staying aligned to the anchor.Resize behavior adds top and corner handles, adjusts handle hit areas, fixes vertical resize to follow pointer movement (not symmetric doubling), and shows corner grip indicators; expanded state clears when the panel hides.
Tab store auto-collapses floating chat when you open, select, or cycle to a different session (or close the active session and land on another); reopening the same session leaves chat open. Toolbar and empty-state tweaks trim icons and polish expand/chat-title controls.
New
persistent-chatcomponent tests cover anchoring, resize handles, expand alignment, and expanded reset on close; chat-mode tests cover session-navigation collapse rules.Reviewed by Cursor Bugbot for commit 7a3def6. Bugbot is set up for automated code reviews on this repo. Configure here.