fix: resolve lint issues across the codebase#2337
Conversation
- Fix no-floating-promises warnings by adding void operator for fire-and-forget calls - Fix exhaustive-deps warnings in React hooks by adding missing dependencies - Fix restrict-template-expressions warnings by properly typing template literals - Fix no-useless-escape warnings in regex patterns - Fix no-useless-rename warnings in destructuring - Fix no-unused-expressions warnings - Fix @tanstack/query/no-unstable-deps errors by destructuring query results - Fix no-constant-condition warnings by removing ternary operators with constant conditions Remaining issues are: - tsconfig baseUrl errors (configuration issues, not code) - unbound-method warnings in test files (intentional patterns) - Simple unused variable warnings (as requested to skip) - Generated files (api-client, routeTree.gen.ts) Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Note Free review on us!CodeRabbit is offering free reviews until Wed Dec 17 2025 to showcase some of the refinements we've made. Comment |
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
fix: resolve lint issues across the codebase
Summary
This PR manually fixes lint issues identified by
pnpm lint(oxlint + eslint). The changes span 66 files and address the following categories:voidoperator to fire-and-forget async calls (analytics events, navigation, cache invalidation, etc.)error instanceof Error ? error.message : String(error)useCallback,useMemo)ifstatementsRemaining issues not addressed (as requested):
tsconfig baseUrlerrors (configuration issues, not code)unbound-methodwarnings in test files (intentional patterns)routeTree.gen.ts,api-client)Updates since last revision
eslint-disablecomment for compile-time type check in__root.tsxdprint fmtformatting to 6 filesReview & Testing Checklist for Human
React hook dependency changes - Verify these don't cause infinite loops or unexpected re-renders:
useAutoTitle.ts:51- Changed from[title, model, titleTask.status, titleTask.start, sessionId]to[title, model, titleTask, sessionId]useStartListening.ts:115- Addeduser_id, record_enabledto depscloudPersister.ts:192- Addeduser_id, storeto depsControl flow changes in
timeline.ts- Converted&&expressions toifstatements (lines 163-205). Verify timeline still renders correctly.localPersister.tslogging changes - Removed conditional logging (wasfalse ? console.log : () => {}). Debug logging is now disabled, error logging remains.Run the desktop app locally and verify basic functionality (recording, navigation, settings)
Recommended test plan: Start the desktop app, create a new session, start/stop recording, navigate between tabs, and verify the timeline displays correctly.
Notes
Requested by: @yujonglee (yujonglee.dev@gmail.com)
Link to Devin run: https://app.devin.ai/sessions/f566ab36d9ed41088fb6a282c0f0563c