fix: resolve lint errors and safe warnings#2345
Merged
Conversation
- Remove deprecated baseUrl from tsconfig.json files (packages/ui, apps/pro, apps/web) - Remove unused eslint-disable directive in __root.tsx - Fix no-misused-spread in apps/bot/src/devin/shared.ts by using Headers API - Fix unused catch parameters by using empty catch blocks - Fix unused destructured variable by prefixing with underscore Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 3 lint errors and several safe warnings reported by
pnpm lint:Errors fixed:
baseUrloption from tsconfig.json files inpackages/ui,apps/pro, andapps/web. The oxlint tsgolint parser doesn't support this option, and it's redundant since all path aliases use relative notation (./).Warnings fixed:
no-misused-spreadinapps/bot/src/devin/shared.tsby using the Headers API instead of spreadinginit?.headers(which could be a Headers object or array)__root.tsxorder→_order)Review & Testing Checklist for Human
packages/ui,apps/pro, andapps/web(runpnpm buildor check IDE imports)shared.tsdoesn't break Devin API calls (the behavior should be identical - Authorization header is set/overwritten)Notes
Remaining warnings (72) were intentionally not fixed as they involve:
Link to Devin run: https://app.devin.ai/sessions/36325da9de4940859d700b9ab47918e3
Requested by: yujonglee (@yujonglee)