refactor: use useResizeObserver hook from usehooks-ts#2346
Merged
Conversation
- Refactor useScrollState in body/index.tsx to use useResizeObserver with onResize callback - Refactor ProfileSection in sidebar/profile/index.tsx to use useResizeObserver with onResize callback - Remove manual ResizeObserver instantiation in favor of the hook Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ Deploy Preview for hyprnote failed.
|
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors two usages of raw
ResizeObserverto use theuseResizeObserverhook fromusehooks-ts:useScrollStateinbody/index.tsx: Replaced manualResizeObserverinstantiation with the hook'sonResizecallback pattern. The scroll event listener remains in a separateuseEffect.ProfileSectioninsidebar/profile/index.tsx: Replaced auseLayoutEffectwith manualResizeObserverwith the hook. The conditional logic (only update height when expanded and on main view) is preserved in the callback.Note: A third usage in
useAutoScroll(transcript hooks) was intentionally left unchanged because it observes multiple dynamic elements ([data-virtual-root]), which the hook doesn't support.Review & Testing Checklist for Human
useLayoutEffectwhich is synchronous; the hook usesuseEffectinternally which could cause timing differences.Notes