Conversation
… tiptap core Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for howto-fix-macos-audio-selection canceled.
|
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the tiptap warning:
[tiptap warn]: Duplicate extension names found: ['clipboardTextSerializer']. This can lead to issues.The warning appeared because our custom
ClipboardTextSerializerextension had the same name as a built-in tiptap v3 core extension (referenced in tiptap docs ascoreExtensionOptions.clipboardTextSerializer). This PR renames both the extension name and its ProseMirror PluginKey tohyprnoteClipboardTextSerializerto avoid the collision.The
clipboardTextSerializerprop in ProseMirror'spropsobject is unchanged since that's the actual prop name, not our extension's identifier.Review & Testing Checklist for Human
Notes
Link to Devin run: https://app.devin.ai/sessions/291c297bf1734505bc70a43a9ed52980
Requested by: @yujonglee (yujonglee.dev@gmail.com)