refactor: extract HyprCloudCTAButton and unify cloud UI

[yujonglee]

Summary

• Extracts duplicated cloud CTA button logic into a shared HyprCloudCTAButton component (used by both STT and LLM settings)
• Removes requires_entitlement: pro from the hyprnote LLM provider definition — auth is now sufficient for eligibility, matching the STT pattern
• Gates non-pro users at the dropdown interaction level: selecting hyprnote in the LLM provider dropdown calls upgradeToPro() instead of changing the provider
• Moves Pro lock check from useConfiguredMapping (proLocked field) into the provider dropdown render, reading directly from provider.requirements
• Auto-opens the hyprnote accordion when no LLM provider is configured, improving onboarding UX
• Renames display labels: "Pro" → "Pro (Cloud)" and "Cloud" → "Pro (Cloud)" for consistency
• Adds Pro badge + lock state to provider select dropdown items (for any provider with requires_entitlement: pro)

Updates since last revision

• Reverted the earlier requires_entitlement: pro restoration on the hyprnote provider (keeping it removed was intentional)
• Instead, added an onValueChange interceptor in the LLM provider Select: when a non-pro user picks "hyprnote", it calls billing.upgradeToPro() and returns early without changing the form value — same gating pattern as STT

Review & Testing Checklist for Human

• As a non-pro user, select "hyprnote" from the LLM provider dropdown and confirm it triggers the upgrade flow (not setting the provider/model). This is the key fix — the dropdown item will appear enabled but the interaction is intercepted.
• As a non-pro user, confirm the hyprnote accordion CTA button ("Start Free Trial" / "Upgrade to Pro") also redirects to upgrade correctly — this is the HyprProviderAutoRow path which has its own isPro gate.
• As a pro user, confirm selecting "hyprnote" from the dropdown sets provider to "hyprnote" / model to "Auto"
• Verify HyprCloudCTAButton shows correct label in both STT and LLM settings (Ready to use / Start Free Trial / Upgrade to Pro)
• Confirm hyprnote accordion opens by default when no LLM provider is configured

Notes

Since requires_entitlement: pro was removed from the hyprnote provider definition, the Pro badge and "Upgrade to Pro" hint text in the dropdown won't render for hyprnote specifically (those are driven by requiresEntitlement(provider.requirements, "pro")). The guard is purely behavioral via onValueChange. Verify this UX is acceptable.

Requested by @yujonglee | Devin session

[netlify]

✅ Deploy Preview for hyprnote canceled.

Name	Link
🔨 Latest commit	1fb003c
🔍 Latest deploy log	https://app.netlify.com/projects/hyprnote/deploys/69993054b82f5700084cae19

[netlify]

✅ Deploy Preview for hyprnote-storybook canceled.

Name	Link
🔨 Latest commit	1fb003c
🔍 Latest deploy log	https://app.netlify.com/projects/hyprnote-storybook/deploys/69993054c1324d000836de29

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}