feat: replace floating chat with persistent panel#4283
Merged
ComputelessComputer merged 3 commits intomainfrom Feb 26, 2026
Merged
feat: replace floating chat with persistent panel#4283ComputelessComputer merged 3 commits intomainfrom
ComputelessComputer merged 3 commits intomainfrom
Conversation
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
ComputelessComputer
requested review from
yujonglee
and removed request for
yujonglee
Replace ChatView with PersistentChatPanel that renders chat in both floating and panel modes. Add portal-like rendering system using container refs and position tracking. Remove auto-closer logic from floating button component and simplify its render conditions.
ComputelessComputer
force-pushed
the
c-branch-3
branch
from
76c051f to
ed17c71
Compare
ComputelessComputer
requested review from
yujonglee
and removed request for
yujonglee
Remove createPortal usage in floating component to render directly in component tree instead of document body. This simplifies the component structure and eliminates the need for portal-based rendering while maintaining the same visual positioning through CSS positioning.
Replace symmetric px-2.5 padding with asymmetric pl-2.5 pr-1.5 padding on the chat input submit button to improve visual balance and alignment with adjacent UI elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace ChatView with PersistentChatPanel that renders chat in both floating and panel modes. Add portal-like rendering system using container refs and position tracking. Remove auto-closer logic from floating button component and simplify its render conditions.