-
Notifications
You must be signed in to change notification settings - Fork 433
fix landing #1661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix landing #1661
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughAdds three new blog articles about meeting practices and refactors the documentation architecture by removing numerous legacy docs pages, introducing a new DocLayout component, and converting docs routing from slug-based to splat-based parameters. Minor styling updates adjust table of contents sticky positioning, and router configuration adds scroll restoration. Changes
Sequence DiagramsequenceDiagram
participant User
participant Router
participant OldRoute as Old Routing<br/>(Slug-based)
participant NewRoute as New Routing<br/>(Splat-based)
participant DocLayout
participant Doc
Note over User,Doc: OLD ARCHITECTURE
User->>Router: Navigate to /docs/foo/bar
Router->>OldRoute: Match /docs/$slug
OldRoute->>OldRoute: Extract slug from route
OldRoute->>Doc: Load doc via slug
Doc-->>OldRoute: Doc object
OldRoute->>OldRoute: Compose ArticleHeader<br/>+ ArticleContent<br/>+ ArticleFooter<br/>+ Sidebar
OldRoute-->>User: Render multi-part layout
Note over User,Doc: NEW ARCHITECTURE
User->>Router: Navigate to /docs/foo/bar
Router->>NewRoute: Match /docs/$
NewRoute->>NewRoute: Extract path via _splat
NewRoute->>Doc: Load doc via _splat
Doc-->>NewRoute: Doc object
NewRoute->>DocLayout: Pass doc + showSectionTitle
rect rgba(100, 200, 100, 0.2)
Note over DocLayout: New centralized<br/>component
DocLayout->>DocLayout: Render ArticleHeader<br/>(with section title control)<br/>+ ArticleContent<br/>+ ArticleFooter
end
DocLayout-->>User: Render unified layout
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Suggested reviewers
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (31)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
No description provided.