Skip to content

Conversation

@ComputelessComputer
Copy link
Collaborator

No description provided.

@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for hyprnote ready!

Name Link
🔨 Latest commit 7664f4d
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/6925d0ea9a46f300089ae3ea
😎 Deploy Preview https://deploy-preview-1893--hyprnote.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ComputelessComputer ComputelessComputer merged commit 91f023b into main Nov 25, 2025
5 of 7 checks passed
@ComputelessComputer ComputelessComputer deleted the jj-branch-26 branch November 25, 2025 15:53
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 25, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The documentation routing system is reorganized by moving docsStructure from -structure.tsx to a new structure.ts file, updating import paths, and refactoring the route handler to separate preprocessing logic (via beforeLoad) from data fetching (via loader), introducing normalization and redirect flows.

Changes

Cohort / File(s) Summary
Structure definition reorganization
apps/web/src/routes/_view/docs/-structure.tsx, apps/web/src/routes/_view/docs/structure.ts
Moved docsStructure export from -structure.tsx to new structure.ts file; expanded definition to include defaultPages mapping (about → "about/hello-world", developers → "developers/analytics", pro → "pro/activation") alongside existing sections array.
Route handler refactoring
apps/web/src/routes/_view/docs/$.tsx
Replaced single loader with beforeLoad for preprocessing (parameter normalization, redirect logic, default page mapping) and a separate loader for data fetching; added redirect flows for missing docs and default page resolution.
Import path correction
apps/web/src/routes/_view/docs/route.tsx
Updated docsStructure import path from invalid "./-structure" to correct "./structure" module.

Sequence Diagram

sequenceDiagram
    participant User
    participant beforeLoad
    participant loader
    participant Render

    User->>beforeLoad: Navigate to docs route
    beforeLoad->>beforeLoad: Normalize _splat parameter
    alt Default page exists
        beforeLoad->>User: Redirect to default page
    else Doc not found
        alt Is fallback doc
            beforeLoad->>Render: Return early (show fallback)
        else Not fallback doc
            beforeLoad->>User: Redirect to "about/hello-world"
        end
    else Doc found
        beforeLoad->>loader: Continue to loader
        loader->>loader: Fetch doc by normalized path<br/>or path/index variant
        loader->>Render: Return doc data
    end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • $.tsx refactoring: Review the new beforeLoad preprocessing logic, normalization rules, redirect conditions, and interaction with the new defaultPages mapping
  • Import path changes: Verify all references to docsStructure across files use the correct ./structure module path
  • Structure definition expansion: Confirm the new defaultPages mapping is comprehensive and correctly typed

Possibly related PRs

  • fix landing #1661: Directly modifies the same docs route files (apps/web/src/routes/_view/docs/*.tsx and docs structure) with related routing and structure changes.

Suggested reviewers

  • yujonglee
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jj-branch-26

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f94e83f and 7664f4d.

📒 Files selected for processing (4)
  • apps/web/src/routes/_view/docs/$.tsx (1 hunks)
  • apps/web/src/routes/_view/docs/-structure.tsx (0 hunks)
  • apps/web/src/routes/_view/docs/route.tsx (1 hunks)
  • apps/web/src/routes/_view/docs/structure.ts (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for hyprnote-storybook ready!

Name Link
🔨 Latest commit 7664f4d
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/6925d0eaffa36f0008db92ec
😎 Deploy Preview https://deploy-preview-1893--hyprnote-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@argos-ci
Copy link

argos-ci bot commented Nov 25, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
web (Inspect) ⚠️ Changes detected (Review) 2 changed Nov 25, 2025, 3:56 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants