bunch of new pages #1691

ComputelessComputer · 2025-11-17T08:06:27Z

No description provided.

coderabbitai · 2025-11-17T08:06:46Z

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Adds 11 new file-based TanStack React Router routes under apps/web/src/routes/_view/ that export Route constants and local RouteComponent placeholders rendering simple static messages.

Changes

Cohort / File(s)	Summary
Product & Security Routes `apps/web/src/routes/_view/product/opensource.tsx`, `apps/web/src/routes/_view/security.tsx`	Add two new top-level route modules exporting `Route` constants wired to paths `/_view/product/opensource` and `/_view/security`, each with a local placeholder `RouteComponent`.
Solution Routes `apps/web/src/routes/_view/solution/customer-success.tsx`, `apps/web/src/routes/_view/solution/field-engineering.tsx`, `apps/web/src/routes/_view/solution/government.tsx`, `apps/web/src/routes/_view/solution/healthcare.tsx`, `apps/web/src/routes/_view/solution/legal.tsx`, `apps/web/src/routes/_view/solution/media.tsx`, `apps/web/src/routes/_view/solution/project-management.tsx`, `apps/web/src/routes/_view/solution/recruiting.tsx`, `apps/web/src/routes/_view/solution/sales.tsx`	Add nine new solution-specific route modules exporting `Route` constants created via `createFileRoute(...)` mapping to their respective `/_view/solution/*` paths, each with a local placeholder `RouteComponent`.

Sequence Diagram(s)

sequenceDiagram
  participant U as User (browser)
  participant B as Browser Router
  participant R as TanStack Router
  participant C as RouteComponent (new files)

  U->>B: Navigate to /_view/solution/sales
  B->>R: Match file-based route for path
  alt route found
    R->>C: Render RouteComponent for /_view/solution/sales
    C-->>U: Return placeholder UI ("Hello \"/_view/solution/sales\"!")
  else no match
    R-->>U: 404 / fallback
  end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Homogeneous, boilerplate additions across 11 files with minimal logic.
Review focus: correct path strings, proper createFileRoute usage, and exports.

Possibly related PRs

bunch of new pages #1691: Adds/edits the same set of route modules under apps/web/src/routes/_view/, likely overlapping route additions.
expanding landing page #1632: Also modifies routing by adding multiple apps/web/src/routes/_view/ route files, related at the file/path level.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 2 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.
Title check	❓ Inconclusive	The title 'bunch of new pages' is vague and uses a non-descriptive term that doesn't convey specific information about which pages or what they do.	Replace with a more descriptive title that specifies the route pages being added, e.g., 'Add new route pages for product, security, and solutions sections'.
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess relevance to the changeset.	Add a description explaining the new route pages being added, their purpose, and any relevant context for reviewers.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 46562ec and 71b0d60.

📒 Files selected for processing (1)

apps/web/src/routes/_view/security.tsx (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8e7d847 and 46562ec.

⛔ Files ignored due to path filters (1)

apps/web/src/routeTree.gen.ts is excluded by !**/*.gen.ts

📒 Files selected for processing (11)

apps/web/src/routes/_view/product/opensource.tsx (1 hunks)
apps/web/src/routes/_view/security.tsx (1 hunks)
apps/web/src/routes/_view/solution/customer-success.tsx (1 hunks)
apps/web/src/routes/_view/solution/field-engineering.tsx (1 hunks)
apps/web/src/routes/_view/solution/government.tsx (1 hunks)
apps/web/src/routes/_view/solution/healthcare.tsx (1 hunks)
apps/web/src/routes/_view/solution/legal.tsx (1 hunks)
apps/web/src/routes/_view/solution/media.tsx (1 hunks)
apps/web/src/routes/_view/solution/project-management.tsx (1 hunks)
apps/web/src/routes/_view/solution/recruiting.tsx (1 hunks)
apps/web/src/routes/_view/solution/sales.tsx (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (11)

apps/web/src/routes/_view/product/opensource.tsx (10)

apps/web/src/routes/_view/solution/project-management.tsx (10)

apps/web/src/routes/_view/security.tsx (1)

apps/web/src/routes/_view/solution/healthcare.tsx (10)

apps/web/src/routes/_view/solution/media.tsx (10)

apps/web/src/routes/_view/solution/sales.tsx (10)

apps/web/src/routes/_view/solution/recruiting.tsx (10)

apps/web/src/routes/_view/solution/government.tsx (10)

apps/web/src/routes/_view/solution/legal.tsx (10)

apps/web/src/routes/_view/solution/customer-success.tsx (10)

apps/web/src/routes/_view/solution/field-engineering.tsx (8)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: fmt

🔇 Additional comments (10)

apps/web/src/routes/_view/security.tsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

feat(routes): add solution routes and sales page component

46562ec

coderabbitai bot reviewed Nov 17, 2025

View reviewed changes

apps/web/src/routes/_view/security.tsx Show resolved Hide resolved

Update apps/web/src/routes/_view/security.tsx

71b0d60

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

yujonglee merged commit 1123537 into main Nov 17, 2025
2 of 3 checks passed

yujonglee deleted the web/new-pages branch November 17, 2025 09:03

coderabbitai bot mentioned this pull request Nov 18, 2025

seo related stuff #1706

Merged

This was referenced Nov 28, 2025

Add SEO-ready pages, template pages with OG images, and shortcuts collection #1968

Merged

feat(web): add SEO-ready open source landing page #1980

Merged

Add security and privacy pages to showcase data protection commitment #2054

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

bunch of new pages #1691

bunch of new pages #1691

Uh oh!

ComputelessComputer commented Nov 17, 2025

Uh oh!

coderabbitai bot commented Nov 17, 2025 •

edited

Loading

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bunch of new pages #1691

bunch of new pages #1691

Uh oh!

Conversation

ComputelessComputer commented Nov 17, 2025

Uh oh!

coderabbitai bot commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Nov 17, 2025 •

edited

Loading