attempt to fix netlify deploy #1701
Conversation
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Rate limit exceeded@yujonglee has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 42 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe changes remove a GitHub Actions deployment workflow, update Netlify configuration to adjust the publish path and remove edge function registration, and refactor the OG image generation edge function to use Zod schema validation with data-driven rendering based on query parameters. Changes
Sequence DiagramsequenceDiagram
actor Client
participant Handler as OG Handler
participant Parser as parseSearchParams
participant Renderer as renderTemplate
participant Response as ImageResponse
Client->>Handler: GET /og?title=...&headers=...
Handler->>Parser: url (request URL)
alt Valid Parameters
Parser-->>Handler: OGSchema (parsed data)
Handler->>Renderer: templateSchema (validated params)
Renderer-->>Handler: React-like structure
Handler->>Response: Create ImageResponse
Response-->>Client: 200 OG Image
else Invalid Parameters
Parser-->>Handler: null
Handler-->>Client: 400 Bad Request
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 2 inconclusive)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
apps/web/netlify/edge-functions/og.tsx (2)
6-12: Consider documenting the intended extensibility pattern.The
OGSchemais defined as a discriminated union with a single template type ("meeting"). While this structure supports future template types, the current implementation only handles one case. If additional template types are planned, consider adding a comment documenting the intended extension pattern.
89-102: Consider adding caching headers to the ImageResponse.The handler correctly validates input and returns appropriate errors. However, OG images are typically static for a given set of parameters and could benefit from HTTP caching to reduce regeneration overhead.
Apply this diff to add caching headers:
// https://unpic.pics/og-edge - return new ImageResponse(renderTemplate(params)); + return new ImageResponse(renderTemplate(params), { + headers: { + "Cache-Control": "public, max-age=31536000, immutable", + }, + });Note: Adjust the
max-agevalue based on how frequently your OG image content changes.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/web_cd.yaml(0 hunks)apps/web/netlify.toml(1 hunks)apps/web/netlify/edge-functions/og.tsx(1 hunks)
💤 Files with no reviewable changes (1)
- .github/workflows/web_cd.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: fmt
🔇 Additional comments (5)
apps/web/netlify/edge-functions/og.tsx (4)
14-25: LGTM!The parsing logic correctly handles URL parameters, uses
getAllfor array values, and safely validates with Zod'ssafeParsemethod. The null return on invalid input integrates well with the error handling in the main handler.
27-87: LGTM!The template rendering is well-structured with appropriate styling for OG image generation. The gradient background, centered card layout, and bullet-point headers create a visually appealing design suitable for social media previews.
104-108: Inline edge function configuration is correct and follows Netlify standards.Netlify supports declaring edge functions entirely inline by exporting a config object from the function file, with no netlify.toml required. The implementation in
og.tsxmatches the documented pattern exactly, with validpathandcacheproperties. The removal of the[[edge_functions]]block fromnetlify.tomlis appropriate and poses no issues.
3-4: Review comment is based on incorrect information.The latest stable Zod npm version is 4.1.12 (published Oct 6, 2025), so Zod version 4 does exist and is actively maintained. The import
npm:zod@^4is valid and will correctly resolve to the latest v4.x release. No changes are required—the code will not fail at runtime due to this import.Likely an incorrect or invalid review comment.
apps/web/netlify.toml (1)
3-3: Publish path configuration is correct.TanStack Start produces client assets in dist/client by default, which aligns with the Netlify publish path set to
"apps/web/dist/client". When the build commandpnpm -F @hypr/web buildruns from the monorepo root, vite outputs to the correct location. No changes needed.
No description provided.