Skip to content

Conversation

@ComputelessComputer
Copy link
Collaborator

• Added error handling for OG image generation
• Implemented dev environment check for OG image generation
• Updated Apple Silicon download URL to nightly channel

@netlify
Copy link

netlify bot commented Nov 19, 2025

Deploy Preview for hyprnote ready!

Name Link
🔨 Latest commit 0d0260c
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/691dd061af28b80008a34ecf
😎 Deploy Preview https://deploy-preview-1734--hyprnote.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ComputelessComputer ComputelessComputer merged commit 2bb6851 into main Nov 19, 2025
6 of 8 checks passed
@ComputelessComputer ComputelessComputer deleted the c-branch-2 branch November 19, 2025 14:13
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 19, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The Netlify OG edge function handler was converted to async with added development environment guard and comprehensive error handling. Separately, the Apple Silicon download route redirect URL was updated to point to a different host and nightly channel.

Changes

Cohort / File(s) Summary
OG Edge Function Enhancement
apps/web/netlify/edge-functions/og.tsx
Handler converted to async. Added development guard returning 503 for localhost requests. Wrapped ImageResponse generation in try/catch block with 500 error responses on failure. Preserved existing parameter validation.
Apple Silicon Download Redirect Update
apps/web/src/routes/_view/download/apple-silicon.tsx
Updated redirect URL from desktop.hyprnote.com (stable channel) to desktop2.hyprnote.com (nightly channel).

Sequence Diagram(s)

sequenceDiagram
    actor Client
    participant Handler as OG Handler
    participant Guard as Dev Guard
    participant ImageGen as ImageResponse
    
    Client->>Handler: Request OG image
    Handler->>Guard: Check if localhost/127.0.0.1
    alt Development Environment
        Guard-->>Client: 503 Service Unavailable (text)
    else Production
        Guard->>ImageGen: Generate image
        alt Success
            ImageGen-->>Client: 200 OK (image)
        else Error
            ImageGen->>Handler: Exception thrown
            Handler-->>Client: 500 Error (JSON)
        end
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • The og.tsx changes introduce straightforward async/await patterns and error handling logic with clear intent
  • The apple-silicon.tsx change is a simple URL constant update
  • Both modifications are localized with minimal cross-file dependencies

Possibly related PRs

Suggested reviewers

  • yujonglee
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch c-branch-2

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cfc41b2 and 0d0260c.

📒 Files selected for processing (2)
  • apps/web/netlify/edge-functions/og.tsx (2 hunks)
  • apps/web/src/routes/_view/download/apple-silicon.tsx (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants