Skip to content

Conversation

@ComputelessComputer
Copy link
Collaborator

  • Simplified changelog OG image generation
  • Removed isNightly parameter from OG image URL generation

@netlify
Copy link

netlify bot commented Nov 24, 2025

Deploy Preview for hyprnote ready!

Name Link
🔨 Latest commit 200a5f1
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/692488546238140008a6e117
😎 Deploy Preview https://deploy-preview-1858--hyprnote.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 24, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The PR removes the explicit isNightly field from the changelog OG schema and refactors the edge function to detect nightly versions from the version string itself. It replaces static ImageResponse imports with dynamic loading and removes dev-mode guards while adjusting rendering logic to branch based on version content.

Changes

Cohort / File(s) Summary
OG Edge Function Schema & Import Refactoring
apps/web/netlify/edge-functions/og.tsx
Removed isNightly field from changelog schema; replaced static with dynamic ImageResponse import inside request handler; removed dev-mode guard that disabled OG generation in dev; refactored rendering to branch on whether version contains "nightly"; updated image assets to use nightly-icon.png for nightly versions and stable-icon.png for stable versions.
Changelog Route OG Metadata
apps/web/src/routes/_view/changelog/$slug.tsx
Removed isNightly query parameter from OG image URL generation; URL now encodes only the version.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • og.tsx requires special attention: Verify nightly detection logic (string-based version parsing replaces explicit flag); confirm dynamic import placement doesn't break error handling; test both nightly and stable rendering paths to ensure visual output matches expectations.
  • slug.tsx: Straightforward parameter removal; verify OG image rendering still works without the flag on both route and edge function sides.

Possibly related PRs

  • #1776: Directly modifies the same OG edge function schema and changelog rendering logic; this PR reverses/refactors changes introduced there.
  • #1725: Modifies the changelog route to remove the same isNightly OG query parameter.
  • #1833: Related changes to changelog OG metadata flow and nightly/version representation in image URLs.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch c-branch-6

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 330202e and 200a5f1.

📒 Files selected for processing (2)
  • apps/web/netlify/edge-functions/og.tsx (3 hunks)
  • apps/web/src/routes/_view/changelog/$slug.tsx (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@ComputelessComputer ComputelessComputer merged commit b330103 into main Nov 24, 2025
5 of 7 checks passed
@ComputelessComputer ComputelessComputer deleted the c-branch-6 branch November 24, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants