-
Notifications
You must be signed in to change notification settings - Fork 433
feat: remove native titlebar on Linux for custom titlebar support #1935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughAdds a Linux-specific conditional to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Summary
Removes the native window decorations (titlebar) on Linux by adding
decorations(false)to the window builder, matching the existing behavior on Windows. This allows the app to display a custom titlebar similar to the macOS version instead of the default Linux window manager titlebar.The change follows the existing pattern in
plugins/windows/src/window/v1.rswhere macOS uses overlay titlebar style and Windows already disables decorations.Local Testing Result
Tested locally on Linux - the native titlebar is successfully removed:
Review & Testing Checklist for Human
data-tauri-drag-region)Notes
data-tauri-drag-regionattributes in place for window draggingcnimport inapps/desktop/src/components/main/sidebar/search/index.tsxLink to Devin run
Requested by: yujonglee (@yujonglee)