Skip to content

Improved anchor navigation with scroll margin and simplified section handling #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2025
Merged

Improved anchor navigation with scroll margin and simplified section handling #2061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a688c3b
style(css): add scroll margin for id elements
ComputelessComputer Dec 2, 2025
b79371e
refactor(ui): simplify section anchor handling
ComputelessComputer Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions apps/web/src/routes/_view/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,11 +289,10 @@ function HeroSection({
return (
<div className="bg-linear-to-b from-stone-50/30 to-stone-100/30">
<div className="flex flex-col items-center text-center">
<section className="relative flex flex-col items-center text-center gap-12 py-24 px-4 laptop:px-0">
<div
id="hero"
className="absolute top-[-69px] h-[69px] pointer-events-none"
/>
<section
id="hero"
className="flex flex-col items-center text-center gap-12 py-24 px-4 laptop:px-0"
>
<div className="space-y-6 max-w-4xl">
<h1 className="text-4xl sm:text-5xl font-serif tracking-tight text-stone-600">
The AI notepad for <br className="block sm:hidden" />
Expand Down
18 changes: 3 additions & 15 deletions apps/web/src/routes/_view/product/ai-assistant.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,7 @@ function HeroSection() {

function BeforeMeetingSection() {
return (
<section className="relative">
<div
id="before-meeting"
className="absolute top-[-69px] h-[69px] pointer-events-none"
/>
<section id="before-meeting">
<div className="text-center font-medium text-neutral-600 uppercase tracking-wide py-6 font-serif">
Before meetings
</div>
Expand Down Expand Up @@ -193,11 +189,7 @@ function BeforeMeetingSection() {

function DuringMeetingSection() {
return (
<section className="relative">
<div
id="during-meeting"
className="absolute top-[-69px] h-[69px] pointer-events-none"
/>
<section id="during-meeting">
<div className="text-center font-medium text-neutral-600 uppercase tracking-wide py-6 font-serif">
During meetings
</div>
Expand Down Expand Up @@ -303,11 +295,7 @@ function DuringMeetingSection() {

function AfterMeetingSection() {
return (
<section className="relative">
<div
id="after-meeting"
className="absolute top-[-69px] h-[69px] pointer-events-none"
/>
<section id="after-meeting">
<div className="text-center font-medium text-neutral-600 uppercase tracking-wide py-6 font-serif">
After meetings
</div>
Expand Down
37 changes: 7 additions & 30 deletions apps/web/src/routes/_view/product/ai-notetaking.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,11 +185,7 @@ function HeroSection() {

function EditorSection() {
return (
<section className="bg-stone-50/30 relative">
<div
id="editor"
className="absolute top-[-69px] h-[69px] pointer-events-none"
/>
<section id="editor" className="bg-stone-50/30">
<div className="hidden sm:grid sm:grid-cols-2">
<div className="flex items-center p-8">
<div className="flex flex-col gap-4">
Expand Down Expand Up @@ -667,11 +663,7 @@ function AnimatedMarkdownDemo({ isMobile = false }: { isMobile?: boolean }) {

function TranscriptionSection() {
return (
<section className="border-y border-neutral-100 relative">
<div
id="transcription"
className="absolute top-[-69px] h-[69px] pointer-events-none"
/>
<section id="transcription" className="border-y border-neutral-100">
<div className="text-center py-12 px-4 lg:px-0">
<h2 className="text-3xl font-serif text-stone-600 mb-4">
Transcription
Expand Down Expand Up @@ -840,11 +832,7 @@ function SummariesSection() {
}, []);

return (
<section className="relative">
<div
id="summaries"
className="absolute top-[-69px] h-[69px] pointer-events-none"
/>
<section id="summaries">
<div className="text-center py-12 px-4 lg:px-0">
<h2 className="text-3xl font-serif text-stone-600 mb-4">
AI summaries
Expand Down Expand Up @@ -1108,15 +1096,12 @@ function SearchSection() {

return (
<section
className="bg-stone-50/30 bg-cover bg-center relative"
id="search"
className="bg-stone-50/30 bg-cover bg-center"
style={{
backgroundImage: "url(/api/images/texture/bg-stars.jpg)",
}}
>
<div
id="search"
className="absolute top-[-69px] h-[69px] pointer-events-none"
/>
<div className="py-20 px-6">
<div className="text-center space-y-12">
<div>
Expand Down Expand Up @@ -1952,11 +1937,7 @@ TrackProtectCell.displayName = "TrackProtectCell";

function SharingSection() {
return (
<section className="relative">
<div
id="sharing"
className="absolute top-[-69px] h-[69px] pointer-events-none"
/>
<section id="sharing">
<div className="text-center py-12 px-4 lg:px-0">
<div className="inline-block px-4 py-1.5 bg-linear-to-t from-neutral-200 to-neutral-100 text-neutral-900 rounded-full shadow-sm text-xs font-medium mb-4">
Coming Soon
Expand Down Expand Up @@ -2180,11 +2161,7 @@ const AUTO_ADVANCE_DURATION = 5000;

function FloatingPanelSection() {
return (
<section className="border-y border-neutral-100 relative">
<div
id="floating-panel"
className="absolute top-[-69px] h-[69px] pointer-events-none"
/>
<section id="floating-panel" className="border-y border-neutral-100">
<FloatingPanelHeader />
<FloatingPanelContent />
</section>
Expand Down
30 changes: 5 additions & 25 deletions apps/web/src/routes/_view/product/mini-apps.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,7 @@ function HeroSection() {

function ContactsSection() {
return (
<section className="bg-stone-50/30 relative">
<div
id="contacts"
className="absolute top-[-69px] h-[69px] pointer-events-none"
/>
<section id="contacts" className="bg-stone-50/30">
<div className="hidden sm:grid sm:grid-cols-2">
<div className="flex items-center p-8">
<div className="flex flex-col gap-4">
Expand Down Expand Up @@ -255,11 +251,7 @@ function ContactsSection() {

function CalendarSection() {
return (
<section className="bg-stone-50/30 relative">
<div
id="calendar"
className="absolute top-[-69px] h-[69px] pointer-events-none"
/>
<section id="calendar" className="bg-stone-50/30">
<div className="hidden sm:grid sm:grid-cols-2">
<div className="flex items-center p-8">
<div className="flex flex-col gap-4">
Expand Down Expand Up @@ -419,11 +411,7 @@ function CalendarSection() {

function DailyNotesSection() {
return (
<section className="bg-stone-50/30 relative">
<div
id="daily-notes"
className="absolute top-[-69px] h-[69px] pointer-events-none"
/>
<section id="daily-notes" className="bg-stone-50/30">
<div className="hidden sm:grid sm:grid-cols-2">
<div className="flex items-center p-8">
<div className="flex flex-col gap-4">
Expand Down Expand Up @@ -521,11 +509,7 @@ function DailyNotesSection() {

function NoteshelfSection() {
return (
<section className="bg-stone-50/30 relative">
<div
id="noteshelf"
className="absolute top-[-69px] h-[69px] pointer-events-none"
/>
<section id="noteshelf" className="bg-stone-50/30">
<div className="hidden sm:grid sm:grid-cols-2">
<div className="flex items-center p-8">
<div className="flex flex-col gap-4">
Expand Down Expand Up @@ -643,11 +627,7 @@ function AdvancedSearchSection() {
];

return (
<section className="bg-stone-50/30 relative">
<div
id="advanced-search"
className="absolute top-[-69px] h-[69px] pointer-events-none"
/>
<section id="advanced-search" className="bg-stone-50/30">
<div>
<div className="text-center">
<div className="py-12 px-6">
Expand Down
6 changes: 6 additions & 0 deletions apps/web/src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@
--breakpoint-laptop: 72rem;
}

@layer base {
[id] {
scroll-margin-top: 69px;
}
}

@layer utilities {
@keyframes shake {
0%,
Expand Down