Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Dec 16, 2025

fix: resolve lint issues across the codebase

Summary

This PR manually fixes lint issues identified by pnpm lint (oxlint + eslint). The changes span 66 files and address the following categories:

  • no-floating-promises: Added void operator to fire-and-forget async calls (analytics events, navigation, cache invalidation, etc.)
  • restrict-template-expressions: Properly stringify error objects in logging using error instanceof Error ? error.message : String(error)
  • exhaustive-deps: Added missing dependencies to React hooks (useCallback, useMemo)
  • no-unused-expressions: Converted logical AND expressions with side effects to proper if statements
  • no-useless-escape: Removed unnecessary escape characters in regex patterns
  • no-constant-condition: Removed ternary operators with constant conditions

Remaining issues not addressed (as requested):

  • Simple unused variable warnings
  • tsconfig baseUrl errors (configuration issues, not code)
  • unbound-method warnings in test files (intentional patterns)
  • Generated files (routeTree.gen.ts, api-client)

Updates since last revision

  • Fixed TypeScript CI failure by adding eslint-disable comment for compile-time type check in __root.tsx
  • Applied dprint fmt formatting to 6 files

Review & Testing Checklist for Human

  • React hook dependency changes - Verify these don't cause infinite loops or unexpected re-renders:

    • useAutoTitle.ts:51 - Changed from [title, model, titleTask.status, titleTask.start, sessionId] to [title, model, titleTask, sessionId]
    • useStartListening.ts:115 - Added user_id, record_enabled to deps
    • cloudPersister.ts:192 - Added user_id, store to deps
  • Control flow changes in timeline.ts - Converted && expressions to if statements (lines 163-205). Verify timeline still renders correctly.

  • localPersister.ts logging changes - Removed conditional logging (was false ? console.log : () => {}). Debug logging is now disabled, error logging remains.

  • Run the desktop app locally and verify basic functionality (recording, navigation, settings)

Recommended test plan: Start the desktop app, create a new session, start/stop recording, navigate between tabs, and verify the timeline displays correctly.

Notes

Requested by: @yujonglee (yujonglee.dev@gmail.com)

Link to Devin run: https://app.devin.ai/sessions/f566ab36d9ed41088fb6a282c0f0563c

- Fix no-floating-promises warnings by adding void operator for fire-and-forget calls
- Fix exhaustive-deps warnings in React hooks by adding missing dependencies
- Fix restrict-template-expressions warnings by properly typing template literals
- Fix no-useless-escape warnings in regex patterns
- Fix no-useless-rename warnings in destructuring
- Fix no-unused-expressions warnings
- Fix @tanstack/query/no-unstable-deps errors by destructuring query results
- Fix no-constant-condition warnings by removing ternary operators with constant conditions

Remaining issues are:
- tsconfig baseUrl errors (configuration issues, not code)
- unbound-method warnings in test files (intentional patterns)
- Simple unused variable warnings (as requested to skip)
- Generated files (api-client, routeTree.gen.ts)

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@netlify
Copy link

netlify bot commented Dec 16, 2025

Deploy Preview for hyprnote ready!

Name Link
🔨 Latest commit 9b7d347
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/69416d3bd37d1d000880edaf
😎 Deploy Preview https://deploy-preview-2337--hyprnote.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 16, 2025

Deploy Preview for hyprnote-storybook ready!

Name Link
🔨 Latest commit 9b7d347
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/69416d3b8d0a240008563cfc
😎 Deploy Preview https://deploy-preview-2337--hyprnote-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Note

Free review on us!

CodeRabbit is offering free reviews until Wed Dec 17 2025 to showcase some of the refinements we've made.

Comment @coderabbitai help to get the list of available commands and usage tips.

devin-ai-integration bot and others added 2 commits December 16, 2025 14:17
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
@yujonglee yujonglee merged commit 19d312e into main Dec 16, 2025
18 of 19 checks passed
@yujonglee yujonglee deleted the devin/1765892894-fix-lint-issues branch December 16, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants