fix: resolve lint issues across the codebase #2337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: resolve lint issues across the codebase
Summary
This PR manually fixes lint issues identified by
pnpm lint(oxlint + eslint). The changes span 66 files and address the following categories:voidoperator to fire-and-forget async calls (analytics events, navigation, cache invalidation, etc.)error instanceof Error ? error.message : String(error)useCallback,useMemo)ifstatementsRemaining issues not addressed (as requested):
tsconfig baseUrlerrors (configuration issues, not code)unbound-methodwarnings in test files (intentional patterns)routeTree.gen.ts,api-client)Updates since last revision
eslint-disablecomment for compile-time type check in__root.tsxdprint fmtformatting to 6 filesReview & Testing Checklist for Human
React hook dependency changes - Verify these don't cause infinite loops or unexpected re-renders:
useAutoTitle.ts:51- Changed from[title, model, titleTask.status, titleTask.start, sessionId]to[title, model, titleTask, sessionId]useStartListening.ts:115- Addeduser_id, record_enabledto depscloudPersister.ts:192- Addeduser_id, storeto depsControl flow changes in
timeline.ts- Converted&&expressions toifstatements (lines 163-205). Verify timeline still renders correctly.localPersister.tslogging changes - Removed conditional logging (wasfalse ? console.log : () => {}). Debug logging is now disabled, error logging remains.Run the desktop app locally and verify basic functionality (recording, navigation, settings)
Recommended test plan: Start the desktop app, create a new session, start/stop recording, navigate between tabs, and verify the timeline displays correctly.
Notes
Requested by: @yujonglee (yujonglee.dev@gmail.com)
Link to Devin run: https://app.devin.ai/sessions/f566ab36d9ed41088fb6a282c0f0563c