Replace Kbd with custom SearchKbd component #2501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+23
to
+37
| function SearchKbd({ children }: { children: React.ReactNode }) { | ||
| return ( | ||
| <kbd | ||
| className={cn([ | ||
| "pointer-events-none inline-flex h-5 w-fit min-w-5 select-none items-center justify-center gap-1 rounded px-1 font-mono text-xs font-medium", | ||
| "border border-neutral-300", | ||
| "bg-linear-to-b from-white to-neutral-100", | ||
| "text-neutral-400", | ||
| "shadow-[0_1px_0_0_rgba(0,0,0,0.1),inset_0_1px_0_0_rgba(255,255,255,0.8)]", | ||
| ])} | ||
| > | ||
| {children} | ||
| </kbd> | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
The SearchKbd component has two issues:
- It uses
bg-linear-to-b, which is an invalid Tailwind class (should bebg-gradient-to-b), causing the background gradient to fail. - It does not accept a
classNameprop, preventing the application of responsive utility classes (e.g.,hidden sm:inline-flex) that were present in the original code. This causes the keyboard shortcut to be visible on mobile devices where it should be hidden.
Update the component to fix the class name and accept className props, then update the usages to restore the responsive classes.
Suggested change
| function SearchKbd({ children }: { children: React.ReactNode }) { | |
| return ( | |
| <kbd | |
| className={cn([ | |
| "pointer-events-none inline-flex h-5 w-fit min-w-5 select-none items-center justify-center gap-1 rounded px-1 font-mono text-xs font-medium", | |
| "border border-neutral-300", | |
| "bg-linear-to-b from-white to-neutral-100", | |
| "text-neutral-400", | |
| "shadow-[0_1px_0_0_rgba(0,0,0,0.1),inset_0_1px_0_0_rgba(255,255,255,0.8)]", | |
| ])} | |
| > | |
| {children} | |
| </kbd> | |
| ); | |
| } | |
| function SearchKbd({ children, className }: { children: React.ReactNode; className?: string }) { | |
| return ( | |
| <kbd | |
| className={cn([ | |
| "pointer-events-none inline-flex h-5 w-fit min-w-5 select-none items-center justify-center gap-1 rounded px-1 font-mono text-xs font-medium", | |
| "border border-neutral-300", | |
| "bg-gradient-to-b from-white to-neutral-100", | |
| "text-neutral-400", | |
| "shadow-[0_1px_0_0_rgba(0,0,0,0.1),inset_0_1px_0_0_rgba(255,255,255,0.8)]", | |
| className, | |
| ])} | |
| > | |
| {children} | |
| </kbd> | |
| ); | |
| } | |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
This comment came from an experimental review—please leave feedback if it was helpful/unhelpful. Learn more about experimental comments here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.