refactor(notification-macos): reorganize Swift file structure for better maintainability #2718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter maintainability Split the monolithic NotificationManager+Helpers.swift (675 lines) into focused, single-responsibility files: - NotificationManager+Layout.swift: positioning and screen calculations - NotificationManager+Creation.swift: UI component factories - NotificationManager+CompactView.swift: compact notification UI - NotificationManager+ExpandedView.swift: expanded notification UI - NotificationManager+Animation.swift: animations and transitions - NotificationManager+MouseTracking.swift: mouse events and hover - NotificationManager+Lifecycle.swift: high-level orchestration Also extracted button classes from NotificationViews.swift into NotificationButtons.swift for better separation of concerns. This refactoring improves code organization without changing functionality. Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for howto-fix-macos-audio-selection canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
yujonglee
deleted the
devin/1767316994-refactor-notification-macos-swift
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(notification-macos): reorganize Swift file structure for maintainability
Summary
Refactors the Swift notification code in
crates/notification-macos/swift-lib/src/by splitting the monolithicNotificationManager+Helpers.swift(675 lines) into focused, single-responsibility extension files:NotificationManager+Layout.swiftNotificationManager+Creation.swiftNotificationManager+CompactView.swiftNotificationManager+ExpandedView.swiftNotificationManager+Animation.swiftNotificationManager+MouseTracking.swiftNotificationManager+Lifecycle.swiftAlso extracted button classes (
CloseButton,ActionButton,DetailsButton) fromNotificationViews.swiftintoNotificationButtons.swift.This is a pure refactoring with no functional changes - the diff shows 873 insertions and 872 deletions (essentially 1:1 code movement).
Review & Testing Checklist for Human
Recommended test plan: Build and run the desktop app on macOS, trigger a notification, and verify:
Notes
repositionNotificationsmethod was consolidated from two similar methods into one with ananimated: Boolparameter - this is the only minor logic change