Component modularization #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yujonglee
force-pushed
the
component-modularization
branch
from
db2a6a1 to
08887ee
Compare
yujonglee
added a commit
that referenced
this pull request
Feb 20, 2025
Co-authored-by: John Jeong <john@padocorp.com>
devin-ai-integration bot
added a commit
that referenced
this pull request
Nov 23, 2025
- Issue #1: Fix partial hints index mismatch after filtering - Added index mapping to track position changes when filtering partial words - Changed filtering condition from > to >= to keep consecutive words - Added comprehensive tests for index adjustment scenarios - Issue #3: Add memory leak prevention safeguards - Implemented MAX_PARTIAL_WORDS (1000) and MAX_PARTIAL_HINTS (1000) limits - Added automatic cleanup when limits are exceeded - Adjusted hint indices when trimming old partial words - Issue #4: Add input validation for transcript handling - Validate channelIndex bounds (0-255) - Verify words are properly ordered by timestamp - Handle undefined channelIndex and missing alternatives gracefully - Issue #5: Improve string matching and add logging - Added console.warn when words not found in transcript - Log includes word, transcript, position, and wordIndex for debugging - Added tests for edge cases (empty transcript, empty words array) - Issue #8: Make gap threshold configurable - Added optional maxGapMs parameter to buildSegments - Defaults to 2000ms when not specified - Allows per-call customization of segment gap threshold All changes follow TDD approach with tests written first, then implementations. All unit tests passing (12 transcript tests, 8 utils tests, 6+ segment tests). Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.