Add membership plugin #910
Conversation
📝 WalkthroughWalkthroughThe changes introduce a new Tauri membership plugin, including its Rust implementation, TypeScript bindings, permissions schema, and configuration files. The plugin provides commands for refreshing and retrieving subscription data, integrates with the app's permission system, and supports serialization and error handling. Supporting files for code generation, documentation, and workspace configuration are also added. Changes
Sequence Diagram(s)sequenceDiagram
participant Frontend (TS)
participant Tauri Plugin (Rust)
participant Remote API
participant Store
Frontend (TS)->>Tauri Plugin (Rust): invoke("refresh")
Tauri Plugin (Rust)->>Remote API: HTTP GET /subscription
Remote API-->>Tauri Plugin (Rust): Subscription data
Tauri Plugin (Rust)->>Store: Update subscription
Tauri Plugin (Rust)-->>Frontend (TS): Subscription
Frontend (TS)->>Tauri Plugin (Rust): invoke("get_subscription")
Tauri Plugin (Rust)->>Store: Retrieve subscription
Store-->>Tauri Plugin (Rust): Subscription or null
Tauri Plugin (Rust)-->>Frontend (TS): Subscription or null
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (9)
plugins/membership/.gitignore (1)
1-18: .gitignore covers common IDE, OS, and build artifacts
The patterns correctly ignore editor configs (.vs,.idea/,.vscode/settings.json,*.sublime*), system files, lockfiles (package-lock.json,yarn.lock,Cargo.lock), build outputs (/target,dist-js,dist) andnode_modules/.Optionally add
pnpm-lock.yamlif this plugin ever usespnpmfor its JS dependencies.plugins/membership/package.json (1)
8-10: Addtypesfield for TS resolution
To ensure IDEs and bundlers pick up your generated TypeScript definitions, consider adding a"types": "./js/bindings.gen.ts"entry alongside"main".plugins/membership/build.rs (1)
1-5: Build script registering commands is straightforward.
DefiningCOMMANDSand invokingtauri_plugin::Builder::new(COMMANDS).build()integrates your Rust handlers into the plugin. Optionally, you could addprintln!("cargo:rerun-if-changed=src/commands.rs");to ensure rebuilds when command code changes, but the current implementation is valid.plugins/membership/permissions/autogenerated/reference.md (1)
5-5: Fix markdown formatting issues in auto-generated documentation.The static analysis tools have identified markdown formatting issues:
- Heading level should be h3 instead of h4 after an h2
- Remove trailing colon from the heading
Since this is auto-generated documentation, consider updating the generation template to fix these formatting issues:
-#### This default permission set includes the following: +### This default permission set includes the following🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
5-5: Heading levels should only increment by one level at a time
Expected: h3; Actual: h4(MD001, heading-increment)
5-5: Trailing punctuation in heading
Punctuation: ':'(MD026, no-trailing-punctuation)
plugins/membership/src/commands.rs (2)
1-10: Consider improving error handling for better debugging.The command structure is correct and follows Tauri patterns well. However, converting all errors to
Stringusingmap_err(|e| e.to_string())loses type information that could be valuable for debugging and error handling on the frontend.Consider defining a serializable error type that preserves more error context:
-) -> Result<Subscription, String> { - app.refresh().await.map_err(|e| e.to_string()) +) -> Result<Subscription, crate::Error> { + app.refresh().awaitThis assumes your
crate::Errortype implementsserde::Serialize, which would provide better error information to the frontend.
12-18: Apply the same error handling improvement here.Same suggestion as above - consider using the typed error instead of converting to
String.-) -> Result<Option<Subscription>, String> { - app.get_subscription().await.map_err(|e| e.to_string()) +) -> Result<Option<Subscription>, crate::Error> { + app.get_subscription().awaitplugins/membership/src/lib.rs (1)
12-20: Consider making runtime type more flexible.The hardcoded
tauri::Wryruntime type in the command collection limits flexibility. While this works for most use cases, it could cause issues if the plugin needs to support other runtimes.Consider making the commands generic over the runtime parameter:
- .commands(tauri_specta::collect_commands![ - commands::refresh::<tauri::Wry>, - commands::get_subscription::<tauri::Wry>, - ]) + .commands(tauri_specta::collect_commands![ + commands::refresh::<R>, + commands::get_subscription::<R>, + ])This would make the plugin more flexible for different runtime environments.
plugins/membership/Cargo.toml (1)
4-4: Update placeholder author information.The
authorsfield contains a placeholder value "You" which should be updated with actual author information before releasing the plugin.-authors = ["You"] +authors = ["Your Name <your.email@example.com>"]plugins/membership/src/ext.rs (1)
26-30: Consider making API URLs configurable.The hardcoded URLs based on debug assertions work for development but could be made more flexible for different environments or deployments.
Consider using environment variables or configuration:
- let url = if cfg!(debug_assertions) { - "http://localhost:1234/api/desktop/subscription" - } else { - "https://app.hypr.com/api/desktop/subscription" - }; + let url = std::env::var("MEMBERSHIP_API_URL") + .unwrap_or_else(|_| { + if cfg!(debug_assertions) { + "http://localhost:1234/api/desktop/subscription".to_string() + } else { + "https://app.hypr.com/api/desktop/subscription".to_string() + } + });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (22)
Cargo.toml(2 hunks)apps/desktop/src-tauri/Cargo.toml(1 hunks)apps/desktop/src-tauri/capabilities/default.json(1 hunks)plugins/membership-interface/Cargo.toml(1 hunks)plugins/membership-interface/src/lib.rs(1 hunks)plugins/membership/.gitignore(1 hunks)plugins/membership/Cargo.toml(1 hunks)plugins/membership/build.rs(1 hunks)plugins/membership/js/bindings.gen.ts(1 hunks)plugins/membership/js/index.ts(1 hunks)plugins/membership/package.json(1 hunks)plugins/membership/permissions/autogenerated/commands/get_subscription.toml(1 hunks)plugins/membership/permissions/autogenerated/commands/refresh.toml(1 hunks)plugins/membership/permissions/autogenerated/reference.md(1 hunks)plugins/membership/permissions/default.toml(1 hunks)plugins/membership/permissions/schemas/schema.json(1 hunks)plugins/membership/src/commands.rs(1 hunks)plugins/membership/src/error.rs(1 hunks)plugins/membership/src/ext.rs(1 hunks)plugins/membership/src/lib.rs(1 hunks)plugins/membership/src/store.rs(1 hunks)plugins/membership/tsconfig.json(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (3)
plugins/membership/src/commands.rs (2)
plugins/membership/js/bindings.gen.ts (2)
Subscription(28-28)refresh(10-12)plugins/membership/src/ext.rs (4)
refresh(9-9)refresh(25-38)get_subscription(8-8)get_subscription(17-23)
plugins/membership-interface/src/lib.rs (1)
plugins/membership/js/bindings.gen.ts (2)
Subscription(28-28)SubscriptionStatus(29-29)
plugins/membership/src/ext.rs (2)
plugins/membership/js/bindings.gen.ts (2)
Subscription(28-28)refresh(10-12)plugins/membership/src/commands.rs (2)
get_subscription(14-18)refresh(6-10)
🪛 GitHub Actions: .github/workflows/desktop_ci.yaml
plugins/membership/package.json
[error] 1-1: pnpm install failed due to outdated lockfile. The pnpm-lock.yaml is not up to date with package.json. Use 'pnpm install --no-frozen-lockfile' to bypass this in CI.
🪛 markdownlint-cli2 (0.17.2)
plugins/membership/permissions/autogenerated/reference.md
5-5: Heading levels should only increment by one level at a time
Expected: h3; Actual: h4
(MD001, heading-increment)
5-5: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
🔇 Additional comments (22)
plugins/membership/permissions/default.toml (1)
1-4:✅ Verification successful
Validate permission identifiers against schema
Please confirm that"allow-refresh"and"allow-get-subscription"exactly match the permission names defined inplugins/membership/permissions/schemas/schema.json, or runtime permission checks will fail.
🏁 Script executed:
#!/usr/bin/env bash # Verify identifiers exist in the schema rg '"allow-refresh"' -n plugins/membership/permissions/schemas/schema.json rg '"allow-get-subscription"' -n plugins/membership/permissions/schemas/schema.jsonLength of output: 251
Permissions validated against schema
Both"allow-refresh"and"allow-get-subscription"have matching entries inplugins/membership/permissions/schemas/schema.json(lines 312 and 300). No further changes required.apps/desktop/src-tauri/Cargo.toml (1)
39-39:✅ Verification successful
New plugin dependency looks correct
Addingtauri-plugin-membership = { workspace = true }aligns with the other Tauri plugins. Make sure you runcargo checkto verify the workspace builds cleanly.Verify that the desktop app’s capabilities include the new membership permission:
🏁 Script executed:
rg '"membership:default"' -n apps/desktop/src-tauri/capabilities/default.jsonLength of output: 108
New plugin dependency and capability verified
Thetauri-plugin-membership = { workspace = true }addition aligns with the other Tauri plugins, and the membership permission is present inapps/desktop/src-tauri/capabilities/default.json(line 51). The workspace builds cleanly withcargo check.plugins/membership-interface/Cargo.toml (2)
6-9: Interface dependencies are appropriate
Usingschemars,serde(derive), andspecta(derive) will enable serialization, schema validation, and TypeScript bindings for your shared types.
1-4:✅ Verification successful
Verify crate name consistency in workspace
The package is declared asmembership-interface. Ensure any workspace dependency key (e.g.,hypr-membership-interface) in the rootCargo.tomlusespackage = "membership-interface"if the key name differs from the crate name.
🏁 Script executed:
#!/usr/bin/env bash # Check for matching dependency entry in root manifest rg 'hypr-membership-interface' -n Cargo.tomlLength of output: 151
Workspace dependency crate name is consistent
The root
Cargo.toml(line 65) already specifies:hypr-membership-interface = { path = "plugins/membership-interface", package = "membership-interface" }No changes required.
plugins/membership/package.json (1)
1-7:❓ Verification inconclusive
Verify
codegenscript behavior
The"codegen": "cargo test -p tauri-plugin-membership"step may be leveraged to emit TypeScript bindings via your test harness—but the name is misleading. Confirm that runningnpm run codegenactually updatesjs/bindings.gen.ts, and consider renaming togenerate-bindingsif it’s not solely for testing.
🏁 Script executed:
#!/usr/bin/env bash npm run codegen # then inspect js/bindings.gen.ts for updatesLength of output: 241
Verify and clarify
codegenscript name and behavior
Thecodegennpm script inplugins/membership/package.jsoncurrently runscargo test -p tauri-plugin-membership, which may not clearly reflect its intent of emitting TypeScript bindings. Please:
- Confirm that executing the script from the plugin root (e.g.
cd plugins/membership && npm run codegenornpm --prefix plugins/membership run codegen) actually updatesjs/bindings.gen.ts.- If its main purpose is to generate bindings rather than run tests, consider renaming it to
generate-bindingsfor clarity.cd plugins/membership npm run codegen # then inspect js/bindings.gen.ts for updates🧰 Tools
🪛 GitHub Actions: .github/workflows/desktop_ci.yaml
[error] 1-1: pnpm install failed due to outdated lockfile. The pnpm-lock.yaml is not up to date with package.json. Use 'pnpm install --no-frozen-lockfile' to bypass this in CI.
plugins/membership/tsconfig.json (1)
1-5: TSConfig looks correct.
Extending the base config and targeting only thejs/*.tssources while excludingnode_modulesaligns with the plugin layout. Review whether you need to capture nested folders (e.g. use**/*.ts) or emit declaration files via"declaration": true, but otherwise this setup is solid.plugins/membership/js/index.ts (1)
1-1: Re-export aggregator is concise and effective.
Usingexport *cleanly surfaces all bindings frombindings.gen.tsas the plugin’s main entry point.plugins/membership/permissions/autogenerated/commands/refresh.toml (1)
1-13: Permissions schema forrefreshis well-formed.
The schema reference path ("$schema" = "../../schemas/schema.json") correctly points to the shared definition, and theallow-refresh/deny-refreshentries map directly to therefreshcommand. Double-check that downstream tooling respects these autogenerated files and that the identifiers align with your registry conventions.plugins/membership/permissions/autogenerated/commands/get_subscription.toml (1)
1-13: Permissions schema forget_subscriptionis consistent.
The structure mirrors therefreshconfig, usingallow-get-subscription/deny-get-subscriptionand the same schema reference. Ensure your permission loader picks up both autogenerated command files.apps/desktop/src-tauri/capabilities/default.json (1)
51-51: LGTM! Permission integration looks correct.The addition of
"membership:default"follows the established pattern and correctly integrates the new membership plugin's default permission set into the desktop app's capabilities.Cargo.toml (2)
65-65: LGTM! Interface dependency follows established pattern.The addition of
hypr-membership-interfacemaintains the consistent workspace dependency structure and alphabetical ordering.
87-87: LGTM! Plugin dependency correctly integrated.The addition of
tauri-plugin-membershipfollows the established pattern for Tauri plugin dependencies and maintains proper organization within the workspace.plugins/membership/permissions/autogenerated/reference.md (1)
6-70: Documentation content looks comprehensive.The permission documentation correctly covers all four permission variants (allow/deny for both commands) and aligns well with the plugin's command structure.
plugins/membership/src/error.rs (1)
1-18: Excellent error handling implementation.This error enum follows Rust best practices:
- Uses
thiserror::Errorfor clean error definitions- Transparent error wrapping preserves original error context
- Custom
Serializeimplementation appropriately converts errors to strings for frontend consumption- Covers the expected error sources (HTTP requests and store operations)
The implementation is well-structured and consistent with typical Tauri plugin error handling patterns.
plugins/membership/src/store.rs (1)
1-9: LGTM! Clean and well-structured store key implementation.The
StoreKeyenum is properly designed with appropriate trait derives for serialization, type reflection, and storage integration. The implementation follows Tauri plugin best practices.plugins/membership/src/lib.rs (2)
34-45: Excellent TypeScript export configuration.The TypeScript export test is well-configured with appropriate formatting options, bigint handling, and proper file output path. This ensures high-quality generated TypeScript bindings.
47-58: Good plugin integration test setup.The test properly verifies plugin integration by including both the membership plugin and the required store plugin dependency. This ensures the plugin can be initialized correctly in a Tauri app context.
plugins/membership-interface/src/lib.rs (3)
1-9: Excellent use of macro to reduce boilerplate.The
common_derivesmacro effectively reduces repetitive derive attributes while ensuring consistency across all types. This is a clean approach to maintaining consistent trait implementations.
11-18: Well-designed Subscription struct.The
Subscriptionstruct has appropriate fields for subscription management:
statusprovides current subscription statecurrent_period_endusingi64is suitable for Unix timestamps- Optional fields for
trial_endandprice_idhandle varying subscription scenarios appropriately
20-32: Comprehensive subscription status enumeration.The
SubscriptionStatusenum covers all common subscription states that would be expected in a subscription management system. Thesnake_caseserialization ensures consistent API communication.plugins/membership/js/bindings.gen.ts (1)
1-90: Auto-generated bindings look comprehensive and correct.The TypeScript bindings are well-structured with:
- Proper command definitions that match the Rust implementations
- Correct type definitions for
SubscriptionandSubscriptionStatus- Comprehensive event handling utilities with proxy-based implementation
- Appropriate Tauri API imports
The generated code follows TypeScript conventions and provides a clean API for frontend integration.
plugins/membership/permissions/schemas/schema.json (1)
294-328: Permission schema correctly defines membership plugin commands.The
PermissionKindenum properly includes:
- Allow/deny permissions for both
get_subscriptionandrefreshcommands- Default permission set that enables both commands
- Clear descriptions for each permission type
The schema structure follows Tauri conventions and provides comprehensive permission control for the membership plugin.
| let resp = reqwest::get(url).await?; | ||
| let data: Subscription = resp.json().await?; |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Enhance HTTP client configuration.
The HTTP request lacks important configuration such as authentication headers, timeout, and user agent.
Consider enhancing the HTTP request:
- let resp = reqwest::get(url).await?;
+ let client = reqwest::Client::builder()
+ .timeout(std::time::Duration::from_secs(30))
+ .user_agent("hypr-desktop/0.1.0")
+ .build()?;
+
+ let resp = client
+ .get(url)
+ // Add authentication headers if needed
+ // .header("Authorization", "Bearer <token>")
+ .send()
+ .await?;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| let resp = reqwest::get(url).await?; | |
| let data: Subscription = resp.json().await?; | |
| let client = reqwest::Client::builder() | |
| .timeout(std::time::Duration::from_secs(30)) | |
| .user_agent("hypr-desktop/0.1.0") | |
| .build()?; | |
| let resp = client | |
| .get(url) | |
| // Add authentication headers if needed | |
| // .header("Authorization", "Bearer <token>") | |
| .send() | |
| .await?; | |
| let data: Subscription = resp.json().await?; |
🤖 Prompt for AI Agents
In plugins/membership/src/ext.rs around lines 32 to 33, the HTTP request uses
reqwest::get without configuring important options like authentication headers,
timeout, and user agent. Replace reqwest::get with a reqwest::Client instance
where you can set these configurations. Create a client with appropriate timeout
settings, add necessary authentication headers and a user agent header, then use
this client to send the GET request and deserialize the response.
yujonglee
force-pushed
the
membership-plugin
branch
from
241161b to
e360769
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
Cargo.lockis excluded by!**/*.lockpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (28)
Cargo.toml(2 hunks)apps/app/package.json(1 hunks)apps/desktop/package.json(3 hunks)apps/desktop/src-tauri/Cargo.toml(1 hunks)apps/desktop/src-tauri/capabilities/default.json(1 hunks)apps/docs/package.json(1 hunks)packages/tiptap/package.json(2 hunks)packages/ui/package.json(1 hunks)packages/utils/package.json(1 hunks)plugins/membership-interface/Cargo.toml(1 hunks)plugins/membership-interface/src/lib.rs(1 hunks)plugins/membership/.gitignore(1 hunks)plugins/membership/Cargo.toml(1 hunks)plugins/membership/build.rs(1 hunks)plugins/membership/js/bindings.gen.ts(1 hunks)plugins/membership/js/index.ts(1 hunks)plugins/membership/package.json(1 hunks)plugins/membership/permissions/autogenerated/commands/get_subscription.toml(1 hunks)plugins/membership/permissions/autogenerated/commands/refresh.toml(1 hunks)plugins/membership/permissions/autogenerated/reference.md(1 hunks)plugins/membership/permissions/default.toml(1 hunks)plugins/membership/permissions/schemas/schema.json(1 hunks)plugins/membership/src/commands.rs(1 hunks)plugins/membership/src/error.rs(1 hunks)plugins/membership/src/ext.rs(1 hunks)plugins/membership/src/lib.rs(1 hunks)plugins/membership/src/store.rs(1 hunks)plugins/membership/tsconfig.json(1 hunks)
✅ Files skipped from review due to trivial changes (10)
- apps/docs/package.json
- packages/ui/package.json
- packages/utils/package.json
- plugins/membership/permissions/autogenerated/commands/get_subscription.toml
- plugins/membership/permissions/autogenerated/commands/refresh.toml
- packages/tiptap/package.json
- apps/desktop/src-tauri/capabilities/default.json
- apps/app/package.json
- apps/desktop/package.json
- plugins/membership-interface/src/lib.rs
🚧 Files skipped from review as they are similar to previous changes (17)
- plugins/membership-interface/Cargo.toml
- apps/desktop/src-tauri/Cargo.toml
- plugins/membership/build.rs
- plugins/membership/package.json
- plugins/membership/js/index.ts
- plugins/membership/permissions/default.toml
- plugins/membership/tsconfig.json
- plugins/membership/src/error.rs
- plugins/membership/.gitignore
- Cargo.toml
- plugins/membership/src/store.rs
- plugins/membership/src/lib.rs
- plugins/membership/Cargo.toml
- plugins/membership/src/commands.rs
- plugins/membership/src/ext.rs
- plugins/membership/js/bindings.gen.ts
- plugins/membership/permissions/schemas/schema.json
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
plugins/membership/permissions/autogenerated/reference.md
5-5: Heading levels should only increment by one level at a time
Expected: h3; Actual: h4
(MD001, heading-increment)
5-5: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: ci
- GitHub Check: ci (macos, macos-latest)
- GitHub Check: ci (windows, windows-latest)
🔇 Additional comments (1)
plugins/membership/permissions/autogenerated/reference.md (1)
12-70: Permission table is accurate.The HTML table correctly documents each permission identifier and its description, matching the plugin’s commands and schema. No changes required here.
|
|
||
| Default permissions for the plugin | ||
|
|
||
| #### This default permission set includes the following: |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix heading level and remove trailing colon.
The heading jumps from H2 to H4 and ends with a colon, which violates markdownlint rules (MD001, MD026). It should increment by one level (H3) and drop the colon:
-#### This default permission set includes the following:
+### This default permission set includes the following📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #### This default permission set includes the following: | |
| ### This default permission set includes the following |
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
5-5: Heading levels should only increment by one level at a time
Expected: h3; Actual: h4
(MD001, heading-increment)
5-5: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
🤖 Prompt for AI Agents
In plugins/membership/permissions/autogenerated/reference.md at line 5, the
heading level incorrectly jumps from H2 to H4 and ends with a colon, violating
markdownlint rules. Change the heading to H3 by using three hash marks instead
of four and remove the trailing colon to fix the formatting.
| - `allow-refresh` | ||
| - `allow-get-subscription` |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Include full permission identifiers in the default list.
To align with the identifiers in the permission table and avoid ambiguity, update the bullets to use the plugin-prefixed permissions:
- - `allow-refresh`
- - `allow-get-subscription`
+ - `membership:allow-refresh`
+ - `membership:allow-get-subscription`📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - `allow-refresh` | |
| - `allow-get-subscription` | |
| - `membership:allow-refresh` | |
| - `membership:allow-get-subscription` |
🤖 Prompt for AI Agents
In plugins/membership/permissions/autogenerated/reference.md around lines 7 to
8, the permission identifiers are listed without the required plugin prefix.
Update the bullet points to include the full permission identifiers with the
plugin prefix to match the permission table and avoid ambiguity.
Summary by CodeRabbit
New Features
Permissions
Documentation
Chores