Skip to content

Implement overcommit + styleguide #18

Merged
etagwerker merged 6 commits intomainfrom
feature/standard-rb-overcommit
Jul 29, 2021
Merged

Implement overcommit + styleguide #18
etagwerker merged 6 commits intomainfrom
feature/standard-rb-overcommit

Conversation

@etagwerker
Copy link
Copy Markdown
Member

Hey,

This PR adds overcommit + our standard style guide configuration.

Please check it out.

Thanks!

✅ I will abide by the code of conduct.

@etagwerker etagwerker requested a review from fbuys July 29, 2021 03:07
@etagwerker etagwerker mentioned this pull request Jul 29, 2021
Copy link
Copy Markdown
Member

@fbuys fbuys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit to test the new config.
@etagwerker, I approved but before we merge I want to check if you are okay with the additional commit I made. If note I can remove it and merge after that.

Comment thread .gitignore
@etagwerker
Copy link
Copy Markdown
Member Author

@buys-fran Great, thanks! 👍

@etagwerker etagwerker merged commit 5ff3cb7 into main Jul 29, 2021
@etagwerker etagwerker deleted the feature/standard-rb-overcommit branch July 29, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants