Merged
Conversation
Closed
fbuys
approved these changes
Jul 29, 2021
Member
fbuys
left a comment
There was a problem hiding this comment.
I added a commit to test the new config.
@etagwerker, I approved but before we merge I want to check if you are okay with the additional commit I made. If note I can remove it and merge after that.
Member
Author
|
@buys-fran Great, thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
This PR adds overcommit + our standard style guide configuration.
Please check it out.
Thanks!
✅ I will abide by the code of conduct.