Make sure that we properly calculate the root for the sample file#22
Merged
etagwerker merged 1 commit intomainfrom Aug 31, 2021
Merged
Make sure that we properly calculate the root for the sample file#22etagwerker merged 1 commit intomainfrom
etagwerker merged 1 commit intomainfrom
Conversation
arielj
approved these changes
Aug 24, 2021
Contributor
arielj
left a comment
arielj
left a comment
There was a problem hiding this comment.
Tested and can confirm it shows the correct path for the .env.sample file 👍
I just added a really small formatting comment.
| # | ||
| # Taken from Dotenv source code. | ||
| def self.root | ||
| root_or_pwd =Pathname.new(ENV["RAILS_ROOT"] || Dir.pwd) |
Contributor
There was a problem hiding this comment.
Just beeing nitpicky here, there's a missing space between = and Pathname
etagwerker
force-pushed
the
fixes/sample_file_calculation
branch
from
ea2db50 to
1f5ab48
Compare
Member
Author
|
@arielj thanks for your review! I just addressed it so I'll merge this now. 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
This fixes #21.
It uses
Dotenv's root path calculation mechanism to figure out where we can find the.env.samplefile.Please check it out. Thanks!
I will abide by the code of conduct.