Merged
Conversation
etagwerker
requested changes
Sep 18, 2021
Member
etagwerker
left a comment
etagwerker
left a comment
There was a problem hiding this comment.
@kindoflew Looks good! 👍
Could you please add a note about this change to the README and the CHANGELOG?
Thanks!
Contributor
Author
|
Updated both! Any thoughts on case sensitivity of |
etagwerker
approved these changes
Sep 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34
Description:
Adds:
whencase for'bool'and'boolean'boolean?method to check variableAdditional thought:
Since ENV variables are strings, this just checks that it equals either
'true'or'false'. Francois pointed out that it should maybe also cover both of those capitalized as well.I will abide by the code of conduct.