Merged
Conversation
If .env.sample is not found, we want to make sure that we raise an error that guides the gem user into doing the right thing (they will need to add an .env.sample file to their project)
bronzdoc
reviewed
Sep 20, 2021
| # Taken from Dotenv source code. | ||
| def self.root | ||
| root_or_pwd = Pathname.new(ENV["RAILS_ROOT"] || Dir.pwd) | ||
| root_or_pwd = Pathname.new(ENV['RAILS_ROOT'] || Dir.pwd) |
Contributor
There was a problem hiding this comment.
Why the change to single quotes is needed?
Member
Author
There was a problem hiding this comment.
@bronzdoc If I did not change that, rubocop would complain.
bronzdoc
approved these changes
Sep 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
This PR fixes #24.
Please check it out and let me know if you have any questions.
I will abide by the code of conduct.
Thanks!