Conversation
mateusdeap
force-pushed
the
feature/uuid-format-validator
branch
from
1afd04d to
003c92e
Compare
Member
Author
|
Do I need to bump the version for this? |
Contributor
I don't know if we have a definition on when do we publish new builds you should update the CHANGELOG.md and the README.md though in this PR too |
arielj
requested changes
Nov 26, 2021
Contributor
arielj
left a comment
arielj
left a comment
There was a problem hiding this comment.
changed the approved to request change because the readme should be updated with the new format and the changelog with the new addition
Contributor
|
Looks good once @arielj's updates are added! |
kindoflew
approved these changes
Nov 29, 2021
Member
Author
|
Updated README and CHANGELOG |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This closes #44 by adding the format validator for uuid
I'd like some comments on the specs I wrote. Not sure if I've tested unnecessary cases but since the idea is to validate correct format for the string, I thought it best to try as many invalid formats I could come up with
I will abide by the code of conduct.