Conversation
JuanVqz
force-pushed
the
add-support-ruby-types
branch
from
05a430d to
3a6be8c
Compare
Closes #8 - [x] Add Integer, Float, String, Email, Url, Boolean, and Uuid support - [x] Add tests - [x] Fix some comments **I will abide by the [code of conduct](https://github.com/fastruby/dotenv_checker/blob/main/CODE_OF_CONDUCT.md)**
JuanVqz
force-pushed
the
add-support-ruby-types
branch
from
3a6be8c to
0a3f262
Compare
arielj
reviewed
May 12, 2022
Member
Author
|
@arielj what about Also |
JuanVqz
force-pushed
the
add-support-ruby-types
branch
2 times, most recently
from
a672bf9 to
8b9c17d
Compare
Contributor
|
@arielj -- ping for re-review. thanks! |
Contributor
|
@JuanVqz I think it should be UUID since that's the class name in Ruby (also Uuid looks bad, it's UUID or uuid everywhere, not just ruby). I guess we can leave Boolean since it's a really common type that people might expect that option, but I don't have a preference there, strictly speaking it's not a Ruby type but the meaning is so common that it should be ok |
JuanVqz
force-pushed
the
add-support-ruby-types
branch
from
8b9c17d to
6a6fea9
Compare
Member
Author
|
Done! |
Member
Author
|
Thank you for your feedback! 🦖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8
IMPORTANT: Please read the README before submitting pull requests for this project. Additionally, if your PR closes any open GitHub issues, make sure you include
Closes #XXXXCHANGELOG.mdthat links to this PR under the "main (unreleased)" heading.Description:
I will abide by the code of conduct.