Skip to content

Get Single Record#14

Merged
etagwerker merged 6 commits intofastruby:masterfrom
benphelps:get-single-record
Dec 24, 2018
Merged

Get Single Record#14
etagwerker merged 6 commits intofastruby:masterfrom
benphelps:get-single-record

Conversation

@benphelps
Copy link
Copy Markdown
Contributor

This change adds support for fetching a single record, via methods inherited from Harvesting::Models::Base

Used as such:

harvest = Harvesting::Client.new(access_token: access_token, account_id: account_id)
client = Harvesting::Models::Client.get(7327524, client: harvest)

This is the interface suggest in #5.

@benphelps benphelps mentioned this pull request Oct 22, 2018
Copy link
Copy Markdown
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benphelps This is a great start!

A few things are missing:

@lubc
Copy link
Copy Markdown
Contributor

lubc commented Dec 10, 2018

Hey @benphelps, did you have a chance to look at @etagwerker 's comment? Thanks!

@mscottford
Copy link
Copy Markdown
Collaborator

@lubc I created #22 to try and address the code review comments so that we can get this one merged.

@lthurston
Copy link
Copy Markdown
Contributor

I've created #23, which includes everything from #22 plus gets invoices model working for GET and includes the line items.

Thanks everyone for your efforts on this! @lubc or @etagwerker, do you have a sense as to when you can get this merged in?

@etagwerker etagwerker merged commit a2786dc into fastruby:master Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants