Merged
Conversation
Closed
etagwerker
requested changes
Oct 23, 2018
Member
etagwerker
left a comment
There was a problem hiding this comment.
@benphelps This is a great start!
A few things are missing:
- Could you add documentation to the new public method? If you use https://yardoc.org/ then it will get regenerated here: https://www.rubydoc.info/github/ombulabs/harvesting/Harvesting/Models/Base
- Could you add a spec for the new method? Just make sure you don't commit and push secret credentials in the VCR cassettes.
- Could you add a new example to
README.mdso that other devs can see how to use it?
Contributor
|
Hey @benphelps, did you have a chance to look at @etagwerker 's comment? Thanks! |
Collaborator
Contributor
|
I've created #23, which includes everything from #22 plus gets invoices model working for GET and includes the line items. Thanks everyone for your efforts on this! @lubc or @etagwerker, do you have a sense as to when you can get this merged in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for fetching a single record, via methods inherited from
Harvesting::Models::BaseUsed as such:
This is the interface suggest in #5.