Skip to content
This repository was archived by the owner on Oct 18, 2023. It is now read-only.

[PEC-12] fix word min count#123

Merged
mateusdeap merged 2 commits intomainfrom
PEC-12-fix-word-min-count
Sep 20, 2022
Merged

[PEC-12] fix word min count#123
mateusdeap merged 2 commits intomainfrom
PEC-12-fix-word-min-count

Conversation

@aisayo
Copy link
Copy Markdown
Contributor

@aisayo aisayo commented Aug 23, 2022

https://ombulabs.atlassian.net/browse/PEC-12

Description:

Current Behaviour
Pecas is sending notifications for entries that are less than four words long.

Expected Behaviour
Pecas should only send a notification if the description is empty or if only a Jira ticket is present in the entry

I will abide by the code of conduct.

@aisayo aisayo requested a review from a team as a code owner August 23, 2022 17:04
@aisayo aisayo requested review from KostiantynPopovych and mateusdeap and removed request for a team August 23, 2022 17:04
Copy link
Copy Markdown
Contributor

@kindoflew kindoflew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aisayo aisayo requested a review from ashwinisukale September 8, 2022 12:58
Comment thread spec/domain/time_entry/description_rules_spec.rb
Copy link
Copy Markdown

@ashwinisukale ashwinisukale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some comment on test.

@ashwinisukale ashwinisukale self-requested a review September 9, 2022 16:33
@mateusdeap mateusdeap merged commit b8891ad into main Sep 20, 2022
@mateusdeap mateusdeap deleted the PEC-12-fix-word-min-count branch September 20, 2022 00:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants