Add new param to allow show the migration at the terminal#8
Merged
Add new param to allow show the migration at the terminal#8
Conversation
mauro-oto
reviewed
Feb 1, 2018
Contributor
mauro-oto
left a comment
mauro-oto
left a comment
There was a problem hiding this comment.
Looks good, thanks! Check my comment.
| if write_to_file | ||
| filename = "all_strong_params.rb" | ||
| File.open(filename, "w") { |f| f.write(result) } | ||
| STDOUT.puts "See the strong params result at generated file: #{filename}" |
Contributor
There was a problem hiding this comment.
@cleicar could you try removing STDOUT and just call puts on these lines?
Contributor
Author
|
@mauro-oto Thank you. I just updated my PR. |
Contributor
|
@cleicar looks good, thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to issue #3.
This PR depends on PR #7