bean is not compatible with "ender compile"

[philip-wernersbach]

Using Ender's ender@dev branch from npm, "ender compile" works, except that when bean is included, bean produces broken code in the resulting ender-app.js. This is a big deal because bean is included in the "jeesh" default starter pack for Ender, and this bug breaks "ender compile" by default, unless you remove bean.

philip-wernersbach/ender-compile-is-broken@a7a502092ada83691663409119531e2433799a82 contains a test case for this bug. The bug seems to be in the "integrate" function in bean's Ender wrapper.

[rvagg]

@ded @amccollum ping, I'm not on the ball with ender@dev, can you guys look at this and either fix or let me know what I need to do to fix.

[rvagg]

published fix as bean@1.0.5, let us know if you still have problems with it.

[philip-wernersbach]

Not quite. 5fdbdf6 reverts the code in bean.js that is needed to make this work. I assume this was done because this is an Ender specific fix. I have a fix that adds some code to bean's Ender wrapper to prevent the name mangling in bean itself, fixing this problem. I will file the pull request momentarily.

[amccollum]

@philip-wernersbach, I'm going to go out on a limb and guess that @rvagg's revert was accidental. I think the original change is the right way to address this. Any decent minifier will remove those quotes anyway, so it's not a meaningful change to the code.

[philip-wernersbach]

@amccollum Oops, I didn't consider that the change might have been accidental! I totally agree that the original is the correct way to address this, the alternative fix is a little wonky.

[amccollum]

Actually, this was my bad. I accidentally made the edits to the wrong file. That makes more sense.