-
Notifications
You must be signed in to change notification settings - Fork 33
Use daq_run_id for gcp combine_results #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
==========================================
- Coverage 80.53% 80.24% -0.30%
==========================================
Files 22 22
Lines 3710 3720 +10
==========================================
- Hits 2988 2985 -3
- Misses 722 735 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bin/python/combine_reports.py
Outdated
| [daq_run_id=<nonce>] | ||
| [count=N] | ||
| [from_gcp='true'] | ||
| [from_gcp='true/false'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any string passed here (including false) will be considered true under CONFIG.get('from_gcp'). We can either check if the string is true / false, or revert the doc to only indicate true as an option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it... actually had that fixed but sitting in an unpushed commit on my machine!
PTAL
No description provided.