Skip to content

Conversation

@grafnu
Copy link
Collaborator

@grafnu grafnu commented Aug 24, 2020

No description provided.

@grafnu grafnu requested a review from henry54809 August 24, 2020 16:16
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #616 into master will decrease coverage by 0.29%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
- Coverage   80.53%   80.24%   -0.30%     
==========================================
  Files          22       22              
  Lines        3710     3720      +10     
==========================================
- Hits         2988     2985       -3     
- Misses        722      735      +13     
Flag Coverage Δ
#aux 74.27% <57.14%> (-0.15%) ⬇️
#base 75.83% <57.14%> (-0.07%) ⬇️
#dhcp 72.31% <57.14%> (-0.12%) ⬇️
#many ?
#topo 72.60% <57.14%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
daq/host.py 90.31% <ø> (-0.48%) ⬇️
daq/gcp.py 30.31% <14.28%> (-0.71%) ⬇️
daq/runner.py 87.61% <100.00%> (-0.38%) ⬇️
daq/stream_monitor.py 90.00% <0.00%> (-0.84%) ⬇️
daq/topology.py 96.53% <0.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce3bf1b...704560f. Read the comment docs.

[daq_run_id=<nonce>]
[count=N]
[from_gcp='true']
[from_gcp='true/false']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any string passed here (including false) will be considered true under CONFIG.get('from_gcp'). We can either check if the string is true / false, or revert the doc to only indicate true as an option.

Copy link
Collaborator Author

@grafnu grafnu Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it... actually had that fixed but sitting in an unpushed commit on my machine!

PTAL

@grafnu grafnu merged commit 702baad into faucetsdn:master Aug 24, 2020
@grafnu grafnu deleted the gcpnonce branch August 24, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants