Skip to content

Conversation

@grafnu
Copy link
Collaborator

@grafnu grafnu commented Oct 26, 2020

No description provided.

@grafnu grafnu requested review from henry54809 and pbatta October 26, 2020 21:13
@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #698 into master will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #698      +/-   ##
==========================================
+ Coverage   81.64%   81.96%   +0.31%     
==========================================
  Files          29       29              
  Lines        4054     4059       +5     
==========================================
+ Hits         3310     3327      +17     
+ Misses        744      732      -12     
Flag Coverage Δ
#aux 74.50% <60.00%> (-0.15%) ⬇️
#base 77.13% <100.00%> (+0.64%) ⬆️
#dhcp 73.54% <60.00%> (-0.02%) ⬇️
#many 73.49% <60.00%> (-0.07%) ⬇️
#topo 72.35% <60.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
daq/topology.py 96.63% <100.00%> (-0.17%) ⬇️
daq/stream_monitor.py 90.00% <0.00%> (-0.84%) ⬇️
daq/runner.py 89.79% <0.00%> (+1.02%) ⬆️
daq/base_gateway.py 94.59% <0.00%> (+4.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a692cee...51df4da. Read the comment docs.

@grafnu grafnu merged commit 6643326 into faucetsdn:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants