Skip to content

Conversation

@grafnu
Copy link
Collaborator

@grafnu grafnu commented Oct 30, 2020

No description provided.

@grafnu grafnu requested review from anurag6 and henry54809 October 30, 2020 05:37
@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #701 into master will increase coverage by 0.14%.
The diff coverage is 98.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
+ Coverage   81.76%   81.90%   +0.14%     
==========================================
  Files          29       29              
  Lines        4063     4123      +60     
==========================================
+ Hits         3322     3377      +55     
- Misses        741      746       +5     
Flag Coverage Δ
aux 74.46% <75.65%> (-0.39%) ⬇️
base 77.17% <98.26%> (+0.09%) ⬆️
dhcp 73.51% <75.65%> (-0.11%) ⬇️
many 73.46% <75.65%> (-0.57%) ⬇️
topo 72.30% <75.65%> (-0.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
daq/host.py 90.99% <91.66%> (-0.24%) ⬇️
daq/dhcp_monitor.py 98.88% <96.42%> (+0.15%) ⬆️
daq/network.py 97.20% <100.00%> (ø)
daq/runner.py 89.30% <100.00%> (+0.09%) ⬆️
daq/topology.py 96.86% <100.00%> (+0.03%) ⬆️
daq/base_gateway.py 88.51% <0.00%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5774d74...f338720. Read the comment docs.

@grafnu
Copy link
Collaborator Author

grafnu commented Nov 1, 2020

Took way more than expected, but I fixed all the tests. PTAL.

@grafnu grafnu merged commit 245bb0a into faucetsdn:master Nov 2, 2020
@grafnu grafnu deleted the fot branch November 2, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants